From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ruby-core-bounces@ruby-lang.org>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS4713 221.184.0.0/13
X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_PASS
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1
Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75])
	by dcvr.yhbt.net (Postfix) with ESMTP id 0C0DB1F404
	for <normalperson@yhbt.net>; Wed,  5 Sep 2018 21:47:59 +0000 (UTC)
Received: from neon.ruby-lang.org (localhost [IPv6:::1])
	by neon.ruby-lang.org (Postfix) with ESMTP id EACB8120A10;
	Thu,  6 Sep 2018 06:47:55 +0900 (JST)
Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64])
 by neon.ruby-lang.org (Postfix) with ESMTPS id 140F9120A10
 for <ruby-core@ruby-lang.org>; Thu,  6 Sep 2018 06:47:52 +0900 (JST)
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
 by dcvr.yhbt.net (Postfix) with ESMTP id 367181F404;
 Wed,  5 Sep 2018 21:47:50 +0000 (UTC)
Date: Wed, 5 Sep 2018 21:47:50 +0000
From: Eric Wong <normalperson@yhbt.net>
To: ruby-core@ruby-lang.org
Message-ID: <20180905214750.7r7m5x442qw7jxjn@whir>
References: <redmine.issue-13618.20170601001407@ruby-lang.org>
 <redmine.journal-73880.20180904213641.501865a60acb8dce@ruby-lang.org>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <redmine.journal-73880.20180904213641.501865a60acb8dce@ruby-lang.org>
X-ML-Name: ruby-core
X-Mail-Count: 88873
Subject: [ruby-core:88873] Re: [Ruby trunk Feature#13618] [PATCH] auto fiber
 schedule for rb_wait_for_single_fd and rb_waitpid
X-BeenThere: ruby-core@ruby-lang.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: Ruby developers <ruby-core@ruby-lang.org>
List-Id: Ruby developers <ruby-core.ruby-lang.org>
List-Unsubscribe: <https://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>, 
 <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
List-Post: <mailto:ruby-core@ruby-lang.org>
List-Help: <mailto:ruby-core-request@ruby-lang.org?subject=help>
List-Subscribe: <https://lists.ruby-lang.org/cgi-bin/mailman/listinfo/ruby-core>, 
 <mailto:ruby-core-request@ruby-lang.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ruby-core-bounces@ruby-lang.org
Sender: "ruby-core" <ruby-core-bounces@ruby-lang.org>

Greg.mpls@gmail.com wrote:
> Issue #13618 has been updated by MSP-Greg (Greg L).
> 
> 
> @normalperson  Eric,
> 
> I applied the two patches in 'note 139', and three test suites stopped..  With test-all running parallel, it's difficult to tell what caused the issue.  
> 
> btest - stopped on `#354 test_insns.rb`

OK, extremely unexpected because no I/O happens, there.

> spec - the log looked garbled, so I'm not sure.
> 
> I've downloaded the build, I'll see if I can run some of the tests locally...
> 
> If I misunderstood about what to apply or when, sorry. Thanks, Greg

Thanks Greg,

You can also checkout my git repo @ commit 13c51c9c9ae39dae08497cfe0eb119244c4d2224

https://80x24.org/ruby.git  (branch: coro-r64610)

Can you try breaking out the first patch?  It's only a
restructuring so there should be no OS-dependent changes:

https://80x24.org/spew/20180827201123.4364-1-e@80x24.org/raw
"unify sync_waiter, waitpid_state, waiting_fd w/ rb_sched_waiter"

Thanks.


I still need to fix some problems with my work-in-progress
changes to support SizedQueue/Queue.