From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ruby-core-bounces@ruby-lang.org>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS4713 221.184.0.0/13
X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_PASS
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1
Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75])
	by dcvr.yhbt.net (Postfix) with ESMTP id CFFD01F403
	for <normalperson@yhbt.net>; Mon, 18 Jun 2018 23:06:22 +0000 (UTC)
Received: from neon.ruby-lang.org (localhost [IPv6:::1])
	by neon.ruby-lang.org (Postfix) with ESMTP id 4A741120912;
	Tue, 19 Jun 2018 08:06:20 +0900 (JST)
Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64])
 by neon.ruby-lang.org (Postfix) with ESMTPS id 7727612090C;
 Tue, 19 Jun 2018 08:06:14 +0900 (JST)
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
 by dcvr.yhbt.net (Postfix) with ESMTP id 65B191F403;
 Mon, 18 Jun 2018 23:06:12 +0000 (UTC)
Date: Mon, 18 Jun 2018 23:06:12 +0000
From: Eric Wong <normalperson@yhbt.net>
To: ruby-core@ruby-lang.org
Message-ID: <20180618230612.vq4szbq3mak2kz3l@dcvr>
References: <20180606080347.D09C76B4F3@svn.ruby-lang.org>
 <20180606085829.d4uumjwkgj2ksx4o@dcvr>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20180606085829.d4uumjwkgj2ksx4o@dcvr>
X-ML-Name: ruby-core
X-Mail-Count: 87509
Cc: naruse@ruby-lang.org
Subject: [ruby-core:87509] timeout in core (was: naruse:r63587 (trunk):
 Introduce write_timeout to Net::HTTP [Feature #13396])
X-BeenThere: ruby-core@ruby-lang.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: Ruby developers <ruby-core@ruby-lang.org>
List-Id: Ruby developers <ruby-core.ruby-lang.org>
List-Unsubscribe: <https://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>, 
 <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
List-Post: <mailto:ruby-core@ruby-lang.org>
List-Help: <mailto:ruby-core-request@ruby-lang.org?subject=help>
List-Subscribe: <https://lists.ruby-lang.org/cgi-bin/mailman/listinfo/ruby-core>, 
 <mailto:ruby-core-request@ruby-lang.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ruby-core-bounces@ruby-lang.org
Sender: "ruby-core" <ruby-core-bounces@ruby-lang.org>

Eric Wong <normalperson@yhbt.net> wrote:
> Anyways, the code for handling partial write_nonblock case is verbose.
> One day, I would like to:
> 
> 1) integrate Timeout into core
> 2) make all SOCK_STREAM sockets non-blocking by default
> 3) Make rb_wait_for_single_fd aware of Timeouts

FYI, I'm close to having a patch ready for 1) and 3);
but maybe 3 is optional, even.

> So we can use:
> 
>     Timeout.timeout(@write_timeout) { @io.write(strs) }
> 
> And no new background threads get spawned.

> P.S.: If Ruby were LGPL-2.1+, I would steal the ccan/timer module which
>       is optimized for frequently-expiring timers and be done with 1),
>       already.

ccan/timer may not be the right tool for the job (more on this
later).