From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ruby-core-bounces@ruby-lang.org>
X-Original-To: poffice@blade.nagaokaut.ac.jp
Delivered-To: poffice@blade.nagaokaut.ac.jp
Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24])
	by blade.nagaokaut.ac.jp (Postfix) with ESMTP id D6E1719C0009
	for <poffice@blade.nagaokaut.ac.jp>; Wed,  2 Dec 2015 10:52:55 +0900 (JST)
Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100])
	by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 187DFB5D87A
	for <poffice@blade.nagaokaut.ac.jp>; Wed,  2 Dec 2015 11:24:19 +0900 (JST)
Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75])
	by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 747C118CC7E4
	for <poffice@blade.nagaokaut.ac.jp>; Wed,  2 Dec 2015 11:24:19 +0900 (JST)
Received: from [221.186.184.76] (localhost [IPv6:::1])
	by neon.ruby-lang.org (Postfix) with ESMTP id BE6C61205F1;
	Wed,  2 Dec 2015 11:24:14 +0900 (JST)
X-Original-To: ruby-core@ruby-lang.org
Delivered-To: ruby-core@ruby-lang.org
Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64])
 by neon.ruby-lang.org (Postfix) with ESMTP id 8812E1204B1
 for <ruby-core@ruby-lang.org>; Wed,  2 Dec 2015 11:23:45 +0900 (JST)
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
 by dcvr.yhbt.net (Postfix) with ESMTP id EF89C205E6;
 Wed,  2 Dec 2015 02:23:44 +0000 (UTC)
Date: Wed, 2 Dec 2015 02:23:44 +0000
From: Eric Wong <normalperson@yhbt.net>
To: ruby-core@ruby-lang.org
Message-ID: <20151202022344.GA977@dcvr.yhbt.net>
References: <redmine.issue-11339.20150707215946@ruby-lang.org>
 <redmine.issue-11339.20150707215946.6e54cd7ae76121cc@ruby-lang.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <redmine.issue-11339.20150707215946.6e54cd7ae76121cc@ruby-lang.org>
X-ML-Name: ruby-core
X-Mail-Count: 71789
Subject: [ruby-core:71789] Re: [Ruby trunk - Feature #11339] [Open] [PATCH]
 io.c: avoid kwarg parsing in C API
X-BeenThere: ruby-core@ruby-lang.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: Ruby developers <ruby-core@ruby-lang.org>
List-Id: Ruby developers <ruby-core.ruby-lang.org>
List-Unsubscribe: <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>, 
 <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
List-Post: <mailto:ruby-core@ruby-lang.org>
List-Help: <mailto:ruby-core-request@ruby-lang.org?subject=help>
List-Subscribe: <http://lists.ruby-lang.org/cgi-bin/mailman/listinfo/ruby-core>, 
 <mailto:ruby-core-request@ruby-lang.org?subject=subscribe>
Errors-To: ruby-core-bounces@ruby-lang.org
Sender: "ruby-core" <ruby-core-bounces@ruby-lang.org>

normalperson@yhbt.net wrote:
> https://bugs.ruby-lang.org/issues/11339

For OpenSSL connect_nonblock/accept_nonblock, it seems to be not worth
the effort for a 1% improvement given the overheads of various parts of
OpenSSL.  But I'm also not knowledgeable in OpenSSL, so my benchmark is
also likely bogus:

  http://80x24.org/spew/20151202020654.18328-1-e%4080x24.org/

Additionally, for read_nonblock; calling read_nonblock/sysread
via rb_funcall from inside ossl_ssl_read_internal would also require
more work to avoid the hash allocation.  Not sure if it's worth
the effort at the moment.