From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 4CA7219C001F for ; Wed, 28 Oct 2015 17:35:55 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 9376BB5D89F for ; Wed, 28 Oct 2015 18:03:49 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id AF98B95241E for ; Wed, 28 Oct 2015 18:03:49 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 12C6A1204BD; Wed, 28 Oct 2015 18:03:48 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64]) by neon.ruby-lang.org (Postfix) with ESMTP id EC4CD120497 for ; Wed, 28 Oct 2015 18:03:42 +0900 (JST) Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 747A91F810; Wed, 28 Oct 2015 09:03:41 +0000 (UTC) Date: Wed, 28 Oct 2015 09:03:41 +0000 From: Eric Wong To: Ruby developers Message-ID: <20151028090341.GA29213@dcvr.yhbt.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ML-Name: ruby-core X-Mail-Count: 71241 Subject: [ruby-core:71241] Re: [Ruby trunk - Bug #11384] multi-threaded autoload sometimes fails X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" shugo@ruby-lang.org wrote: > > Eric Wong wrote: > > > http://80x24.org/spew/m/94541be0225540e34f0196e9754ae0eb5c07a4b7.txt > > Your patch looks good to me, and at least it solves the race condition > of autoload_require(), even if there's still another race condition. > Why don't you commit it? Thanks for the reminder. I'll take a closer look at it tomorrow or day after when I'm more awake. It's been eons since I wrote that patch; maybe I did not fully understand the original code I replaced. Will also take another look at Bug #10892, too.