From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ruby-core-bounces@ruby-lang.org>
X-Original-To: poffice@blade.nagaokaut.ac.jp
Delivered-To: poffice@blade.nagaokaut.ac.jp
Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24])
	by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 8F84417D8B2D
	for <poffice@blade.nagaokaut.ac.jp>; Thu, 16 Jul 2015 04:13:23 +0900 (JST)
Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201])
	by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 252A8B5D8E1
	for <poffice@blade.nagaokaut.ac.jp>; Thu, 16 Jul 2015 04:42:02 +0900 (JST)
Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1])
	by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 8397C97A840
	for <poffice@blade.nagaokaut.ac.jp>; Thu, 16 Jul 2015 04:42:02 +0900 (JST)
X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp
Received: from funfun.nagaokaut.ac.jp ([127.0.0.1])
	by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id P_zwZaxZdrpu for <poffice@blade.nagaokaut.ac.jp>;
	Thu, 16 Jul 2015 04:42:02 +0900 (JST)
Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100])
	by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 61D5297A83E
	for <poffice@blade.nagaokaut.ac.jp>; Thu, 16 Jul 2015 04:42:02 +0900 (JST)
Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75])
	by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 09F6795243A
	for <poffice@blade.nagaokaut.ac.jp>; Thu, 16 Jul 2015 04:42:01 +0900 (JST)
Received: from [221.186.184.76] (localhost [IPv6:::1])
	by neon.ruby-lang.org (Postfix) with ESMTP id 6488A12045D;
	Thu, 16 Jul 2015 04:41:59 +0900 (JST)
X-Original-To: ruby-core@ruby-lang.org
Delivered-To: ruby-core@ruby-lang.org
Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64])
 by neon.ruby-lang.org (Postfix) with ESMTP id 9BA30120436
 for <ruby-core@ruby-lang.org>; Thu, 16 Jul 2015 04:41:54 +0900 (JST)
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
 by dcvr.yhbt.net (Postfix) with ESMTP id 47D3520388;
 Wed, 15 Jul 2015 19:41:53 +0000 (UTC)
Date: Wed, 15 Jul 2015 19:41:53 +0000
From: Eric Wong <normalperson@yhbt.net>
To: ruby-core@ruby-lang.org
Message-ID: <20150715194153.GA13673@dcvr.yhbt.net>
References: <redmine.issue-11339.20150707215946@ruby-lang.org>
 <redmine.issue-11339.20150707215946.6e54cd7ae76121cc@ruby-lang.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <redmine.issue-11339.20150707215946.6e54cd7ae76121cc@ruby-lang.org>
X-ML-Name: ruby-core
X-Mail-Count: 69983
Subject: [ruby-core:69983] Re: [Ruby trunk - Feature #11339] [Open] [PATCH]
 io.c: avoid kwarg parsing in C API
X-BeenThere: ruby-core@ruby-lang.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: Ruby developers <ruby-core@ruby-lang.org>
List-Id: Ruby developers <ruby-core.ruby-lang.org>
List-Unsubscribe: <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>, 
 <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
List-Post: <mailto:ruby-core@ruby-lang.org>
List-Help: <mailto:ruby-core-request@ruby-lang.org?subject=help>
List-Subscribe: <http://lists.ruby-lang.org/cgi-bin/mailman/listinfo/ruby-core>, 
 <mailto:ruby-core-request@ruby-lang.org?subject=subscribe>
Errors-To: ruby-core-bounces@ruby-lang.org
Sender: "ruby-core" <ruby-core-bounces@ruby-lang.org>

normalperson@yhbt.net wrote:
> Feature #11339: [PATCH] io.c: avoid kwarg parsing in C API
> https://bugs.ruby-lang.org/issues/11339

> Note: I plan to followup commits for other *_nonblock methods
> Eventually, I even wish to deprecate rb_scan_args :D
> 
> For what it's worth, I'm more excited about this change than usual
> and hope to use prelude.rb more.

ko1/nobu/akr/others: any comments on this?

My main concern is increased parse time from prelude during startup;
but we may translate prelude to iseq array and use rb_iseq_load, too.
The parser seems to be the worst offender for startup performance
nowadays.