From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ruby-core-bounces@ruby-lang.org>
X-Original-To: poffice@blade.nagaokaut.ac.jp
Delivered-To: poffice@blade.nagaokaut.ac.jp
Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24])
	by blade.nagaokaut.ac.jp (Postfix) with ESMTP id B8882196009D
	for <poffice@blade.nagaokaut.ac.jp>; Fri,  3 Jul 2015 16:55:45 +0900 (JST)
Received: from funfun.nagaokaut.ac.jp (smtp.nagaokaut.ac.jp [133.44.2.201])
	by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 9D3ACB5D89A
	for <poffice@blade.nagaokaut.ac.jp>; Fri,  3 Jul 2015 17:21:41 +0900 (JST)
Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1])
	by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 9ECBA97A826
	for <poffice@blade.nagaokaut.ac.jp>; Fri,  3 Jul 2015 17:21:43 +0900 (JST)
X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp
Received: from funfun.nagaokaut.ac.jp ([127.0.0.1])
	by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id ue0CW8_KHSMt for <poffice@blade.nagaokaut.ac.jp>;
	Fri,  3 Jul 2015 17:21:43 +0900 (JST)
Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100])
	by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 7E74097A82C
	for <poffice@blade.nagaokaut.ac.jp>; Fri,  3 Jul 2015 17:21:43 +0900 (JST)
Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75])
	by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 72FDA95243A
	for <poffice@blade.nagaokaut.ac.jp>; Fri,  3 Jul 2015 17:21:41 +0900 (JST)
Received: from [221.186.184.76] (localhost [IPv6:::1])
	by neon.ruby-lang.org (Postfix) with ESMTP id 7CC42120464;
	Fri,  3 Jul 2015 17:21:40 +0900 (JST)
X-Original-To: ruby-core@ruby-lang.org
Delivered-To: ruby-core@ruby-lang.org
Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64])
 by neon.ruby-lang.org (Postfix) with ESMTP id AA0CB120446
 for <ruby-core@ruby-lang.org>; Fri,  3 Jul 2015 17:21:35 +0900 (JST)
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
 by dcvr.yhbt.net (Postfix) with ESMTP id 920A4633848;
 Fri,  3 Jul 2015 08:21:33 +0000 (UTC)
Date: Fri, 3 Jul 2015 08:21:33 +0000
From: Eric Wong <normalperson@yhbt.net>
To: Ruby developers <ruby-core@ruby-lang.org>
Message-ID: <20150703082133.GA6605@dcvr.yhbt.net>
References: <redmine.issue-11326.20150703073852@ruby-lang.org>
 <redmine.issue-11326.20150703073852.fbbcd9e8223bd4b2@ruby-lang.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <redmine.issue-11326.20150703073852.fbbcd9e8223bd4b2@ruby-lang.org>
X-ML-Name: ruby-core
X-Mail-Count: 69850
Subject: [ruby-core:69850] Re: [Ruby trunk - Bug #11326] [Open] Defining a
 writer as a Struct member allowed?
X-BeenThere: ruby-core@ruby-lang.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: Ruby developers <ruby-core@ruby-lang.org>
List-Id: Ruby developers <ruby-core.ruby-lang.org>
List-Unsubscribe: <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>, 
 <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
List-Post: <mailto:ruby-core@ruby-lang.org>
List-Help: <mailto:ruby-core-request@ruby-lang.org?subject=help>
List-Subscribe: <http://lists.ruby-lang.org/cgi-bin/mailman/listinfo/ruby-core>, 
 <mailto:ruby-core-request@ruby-lang.org?subject=subscribe>
Errors-To: ruby-core-bounces@ruby-lang.org
Sender: "ruby-core" <ruby-core-bounces@ruby-lang.org>

peter-rl@suschlik.de wrote:
> I don't have a strong opinion whether defining a writer member should
> be possible or not.

I suggest banning it (barely-tested patch):

--- a/struct.c
+++ b/struct.c
@@ -12,6 +12,7 @@
 #include "internal.h"
 #include "vm_core.h"
 #include "id.h"
+#include "symbol.h"
 
 /* only for struct[:field] access */
 #define AREF_HASH_THRESHOLD (10)
@@ -510,6 +511,10 @@ rb_struct_s_def(int argc, VALUE *argv, VALUE klass)
     rest = rb_ary_tmp_new(argc);
     for (i=0; i<argc; i++) {
 	id = rb_to_id(argv[i]);
+	if (is_attrset_id(id)) {
+	    rb_raise(rb_eArgError, "invalid struct member: %+"PRIsVALUE,
+		     argv[i]);
+	}
 	RARRAY_ASET(rest, i, ID2SYM(id));
 	rb_ary_set_len(rest, i+1);
     }
~~~

$ ./ruby -e 'Struct.new(:foo=)'
-e:1:in `new': invalid struct member: :foo= (ArgumentError)
        from -e:1:in `<main>'