ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:68946] [Ruby trunk - Feature #11084] [Open] Use rb-readline instead of ext/readline
       [not found] <redmine.issue-11084.20150421124337@ruby-lang.org>
@ 2015-04-21 12:43 ` shibata.hiroshi
  2015-04-21 13:30 ` [ruby-core:68947] [Ruby trunk - Feature #11084] " shibata.hiroshi
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: shibata.hiroshi @ 2015-04-21 12:43 UTC (permalink / raw
  To: ruby-core

Issue #11084 has been reported by Hiroshi SHIBATA.

----------------------------------------
Feature #11084: Use rb-readline instead of ext/readline
https://bugs.ruby-lang.org/issues/11084

* Author: Hiroshi SHIBATA
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Users who want to build ruby needs to prepare readline library. 
Example for https://github.com/sstephenson/ruby-build/wiki#suggested-build-environment

Preparation of building environment is hard for many users.

I propose to use rb-readline that it's pure ruby implementation of readline instead of ext/readline.




-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [ruby-core:68947] [Ruby trunk - Feature #11084] Use rb-readline instead of ext/readline
       [not found] <redmine.issue-11084.20150421124337@ruby-lang.org>
  2015-04-21 12:43 ` [ruby-core:68946] [Ruby trunk - Feature #11084] [Open] Use rb-readline instead of ext/readline shibata.hiroshi
@ 2015-04-21 13:30 ` shibata.hiroshi
  2015-04-21 13:48 ` [ruby-core:68948] " usa
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: shibata.hiroshi @ 2015-04-21 13:30 UTC (permalink / raw
  To: ruby-core

Issue #11084 has been updated by Hiroshi SHIBATA.

File rb-readline.patch added

I missed to attach patch.

----------------------------------------
Feature #11084: Use rb-readline instead of ext/readline
https://bugs.ruby-lang.org/issues/11084#change-52205

* Author: Hiroshi SHIBATA
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Users who want to build ruby needs to prepare readline library. 
Example for https://github.com/sstephenson/ruby-build/wiki#suggested-build-environment

Preparation of building environment is hard for many users.

I propose to use rb-readline that it's pure ruby implementation of readline instead of ext/readline.


---Files--------------------------------
rb-readline.patch (99.2 KB)


-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [ruby-core:68948] [Ruby trunk - Feature #11084] Use rb-readline instead of ext/readline
       [not found] <redmine.issue-11084.20150421124337@ruby-lang.org>
  2015-04-21 12:43 ` [ruby-core:68946] [Ruby trunk - Feature #11084] [Open] Use rb-readline instead of ext/readline shibata.hiroshi
  2015-04-21 13:30 ` [ruby-core:68947] [Ruby trunk - Feature #11084] " shibata.hiroshi
@ 2015-04-21 13:48 ` usa
  2015-04-21 13:59 ` [ruby-core:68950] " hanmac
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: usa @ 2015-04-21 13:48 UTC (permalink / raw
  To: ruby-core

Issue #11084 has been updated by Usaku NAKAMURA.


I'm neutral about this issue, but I wonder why you don't simply unbundle ext/readline instead of replacing it by rb-readline.

----------------------------------------
Feature #11084: Use rb-readline instead of ext/readline
https://bugs.ruby-lang.org/issues/11084#change-52206

* Author: Hiroshi SHIBATA
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Users who want to build ruby needs to prepare readline library. 
Example for https://github.com/sstephenson/ruby-build/wiki#suggested-build-environment

Preparation of building environment is hard for many users.

I propose to use rb-readline that it's pure ruby implementation of readline instead of ext/readline.


---Files--------------------------------
rb-readline.patch (99.2 KB)


-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [ruby-core:68950] [Ruby trunk - Feature #11084] Use rb-readline instead of ext/readline
       [not found] <redmine.issue-11084.20150421124337@ruby-lang.org>
                   ` (2 preceding siblings ...)
  2015-04-21 13:48 ` [ruby-core:68948] " usa
@ 2015-04-21 13:59 ` hanmac
  2015-04-21 22:45   ` [ruby-core:68956] " Eric Wong
  2018-01-31  7:14 ` [ruby-core:85280] [Ruby trunk Feature#11084][Assigned] " hsbt
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 8+ messages in thread
From: hanmac @ 2015-04-21 13:59 UTC (permalink / raw
  To: ruby-core

Issue #11084 has been updated by Hans Mackowiak.


i don't know about, the binding/implementation using the C lib might be faster and have more features
so using a pure-ruby implementation might not a 100% good idea

----------------------------------------
Feature #11084: Use rb-readline instead of ext/readline
https://bugs.ruby-lang.org/issues/11084#change-52208

* Author: Hiroshi SHIBATA
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Users who want to build ruby needs to prepare readline library. 
Example for https://github.com/sstephenson/ruby-build/wiki#suggested-build-environment

Preparation of building environment is hard for many users.

I propose to use rb-readline that it's pure ruby implementation of readline instead of ext/readline.


---Files--------------------------------
rb-readline.patch (99.2 KB)


-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [ruby-core:68956] Re: [Ruby trunk - Feature #11084] Use rb-readline instead of ext/readline
  2015-04-21 13:59 ` [ruby-core:68950] " hanmac
@ 2015-04-21 22:45   ` Eric Wong
  0 siblings, 0 replies; 8+ messages in thread
From: Eric Wong @ 2015-04-21 22:45 UTC (permalink / raw
  To: Ruby developers

I doubt performance is problem for readline, but features/compatibility
might be...  I favor a pure-Ruby implementation if there's no
feature/compatibility regressions.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [ruby-core:85280] [Ruby trunk Feature#11084][Assigned] Use rb-readline instead of ext/readline
       [not found] <redmine.issue-11084.20150421124337@ruby-lang.org>
                   ` (3 preceding siblings ...)
  2015-04-21 13:59 ` [ruby-core:68950] " hanmac
@ 2018-01-31  7:14 ` hsbt
  2018-01-31 12:13 ` [ruby-core:85297] [Ruby trunk Feature#11084] " eregontp
  2019-03-05 11:48 ` [ruby-core:91675] " hsbt
  6 siblings, 0 replies; 8+ messages in thread
From: hsbt @ 2018-01-31  7:14 UTC (permalink / raw
  To: ruby-core

Issue #11084 has been updated by hsbt (Hiroshi SHIBATA).

Status changed from Open to Assigned
Assignee set to hsbt (Hiroshi SHIBATA)

----------------------------------------
Feature #11084: Use rb-readline instead of ext/readline
https://bugs.ruby-lang.org/issues/11084#change-70050

* Author: hsbt (Hiroshi SHIBATA)
* Status: Assigned
* Priority: Normal
* Assignee: hsbt (Hiroshi SHIBATA)
* Target version: 
----------------------------------------
Users who want to build ruby needs to prepare readline library. 
Example for https://github.com/sstephenson/ruby-build/wiki#suggested-build-environment

Preparation of building environment is hard for many users.

I propose to use rb-readline that it's pure ruby implementation of readline instead of ext/readline.


---Files--------------------------------
rb-readline.patch (99.2 KB)


-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [ruby-core:85297] [Ruby trunk Feature#11084] Use rb-readline instead of ext/readline
       [not found] <redmine.issue-11084.20150421124337@ruby-lang.org>
                   ` (4 preceding siblings ...)
  2018-01-31  7:14 ` [ruby-core:85280] [Ruby trunk Feature#11084][Assigned] " hsbt
@ 2018-01-31 12:13 ` eregontp
  2019-03-05 11:48 ` [ruby-core:91675] " hsbt
  6 siblings, 0 replies; 8+ messages in thread
From: eregontp @ 2018-01-31 12:13 UTC (permalink / raw
  To: ruby-core

Issue #11084 has been updated by Eregon (Benoit Daloze).


https://github.com/ConnorAtherton/rb-readline/blob/master/lib/rbreadline.rb is almost 9000 lines of Ruby code.
How fast does it load?
That seems important for command-line applications

----------------------------------------
Feature #11084: Use rb-readline instead of ext/readline
https://bugs.ruby-lang.org/issues/11084#change-70078

* Author: hsbt (Hiroshi SHIBATA)
* Status: Assigned
* Priority: Normal
* Assignee: hsbt (Hiroshi SHIBATA)
* Target version: 
----------------------------------------
Users who want to build ruby needs to prepare readline library. 
Example for https://github.com/sstephenson/ruby-build/wiki#suggested-build-environment

Preparation of building environment is hard for many users.

I propose to use rb-readline that it's pure ruby implementation of readline instead of ext/readline.


---Files--------------------------------
rb-readline.patch (99.2 KB)


-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [ruby-core:91675] [Ruby trunk Feature#11084] Use rb-readline instead of ext/readline
       [not found] <redmine.issue-11084.20150421124337@ruby-lang.org>
                   ` (5 preceding siblings ...)
  2018-01-31 12:13 ` [ruby-core:85297] [Ruby trunk Feature#11084] " eregontp
@ 2019-03-05 11:48 ` hsbt
  6 siblings, 0 replies; 8+ messages in thread
From: hsbt @ 2019-03-05 11:48 UTC (permalink / raw
  To: ruby-core

Issue #11084 has been updated by hsbt (Hiroshi SHIBATA).

Status changed from Assigned to Rejected

The last update of rb-readline is 2 years ago. I think we shouldn't replace it. 

And @aycabta try to create the readline alternative. If we replace readline to pure ruby implementation, we should use it.

----------------------------------------
Feature #11084: Use rb-readline instead of ext/readline
https://bugs.ruby-lang.org/issues/11084#change-76936

* Author: hsbt (Hiroshi SHIBATA)
* Status: Rejected
* Priority: Normal
* Assignee: hsbt (Hiroshi SHIBATA)
* Target version: 
----------------------------------------
Users who want to build ruby needs to prepare readline library. 
Example for https://github.com/sstephenson/ruby-build/wiki#suggested-build-environment

Preparation of building environment is hard for many users.

I propose to use rb-readline that it's pure ruby implementation of readline instead of ext/readline.


---Files--------------------------------
rb-readline.patch (99.2 KB)


-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-03-05 11:48 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <redmine.issue-11084.20150421124337@ruby-lang.org>
2015-04-21 12:43 ` [ruby-core:68946] [Ruby trunk - Feature #11084] [Open] Use rb-readline instead of ext/readline shibata.hiroshi
2015-04-21 13:30 ` [ruby-core:68947] [Ruby trunk - Feature #11084] " shibata.hiroshi
2015-04-21 13:48 ` [ruby-core:68948] " usa
2015-04-21 13:59 ` [ruby-core:68950] " hanmac
2015-04-21 22:45   ` [ruby-core:68956] " Eric Wong
2018-01-31  7:14 ` [ruby-core:85280] [Ruby trunk Feature#11084][Assigned] " hsbt
2018-01-31 12:13 ` [ruby-core:85297] [Ruby trunk Feature#11084] " eregontp
2019-03-05 11:48 ` [ruby-core:91675] " hsbt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).