From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 7868117DC9A3 for ; Wed, 26 Nov 2014 17:19:00 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 6F537B5D8D5 for ; Wed, 26 Nov 2014 17:09:31 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 6A81A97A83A for ; Wed, 26 Nov 2014 17:09:33 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2e-hfKXE2MIx for ; Wed, 26 Nov 2014 17:09:33 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 4A2AE97A836 for ; Wed, 26 Nov 2014 17:09:33 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 46D4A95241B for ; Wed, 26 Nov 2014 17:09:31 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 5E93B120503; Wed, 26 Nov 2014 17:09:30 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64]) by neon.ruby-lang.org (Postfix) with ESMTP id 7A05A120450 for ; Wed, 26 Nov 2014 17:09:23 +0900 (JST) Received: from localhost (dcvr.yhbt.net [127.0.0.1]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPSA id DCD541FA55; Wed, 26 Nov 2014 08:09:21 +0000 (UTC) Date: Wed, 26 Nov 2014 08:09:21 +0000 From: Eric Wong To: Ruby developers Message-ID: <20141126080921.GA23225@dcvr.yhbt.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ML-Name: ruby-core X-Mail-Count: 66476 Subject: [ruby-core:66476] Re: [ruby-trunk - Feature #8543] rb_iseq_load X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" nop; nop works, but I don't think it's an improvement (or regression). I prefer to save 2 words entirely. I planned to workaround the issue by doing ISeq#load twice: first = iseq.to_a # useless jump|nop here junk = ISeq.load(first) # second pass optimization removes jump|nop a = ISeq.load(junk.to_a) b = ISeq.load(a.to_a) assert_equal a, b But I encountered other bugs with to_a + load on test/ruby/test_io.rb and test_settracefunc.rb which I have not investigated, yet... Works-in-progress: [PATCH 1/2] http://80x24.org/spew/m/iseq_calc_param_size%40r48578.txt [PATCH 2/2] http://80x24.org/spew/m/rb_iseq_load_fix-v4%40r48578.txt