From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id F3B9217DCA6F for ; Sat, 22 Nov 2014 17:29:46 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 6FBAFB5D911 for ; Sat, 22 Nov 2014 17:19:42 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 6D54197A834 for ; Sat, 22 Nov 2014 17:19:44 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iVIOcqEY6XVU for ; Sat, 22 Nov 2014 17:19:44 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 4CC5697A820 for ; Sat, 22 Nov 2014 17:19:44 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 440DD952408 for ; Sat, 22 Nov 2014 17:19:42 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id EAFD41204B3; Sat, 22 Nov 2014 17:19:40 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64]) by neon.ruby-lang.org (Postfix) with ESMTP id AB17C12049C for ; Sat, 22 Nov 2014 17:19:33 +0900 (JST) Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 0EE6F1F45F; Sat, 22 Nov 2014 08:19:32 +0000 (UTC) Date: Sat, 22 Nov 2014 08:19:31 +0000 From: Eric Wong To: Ruby developers Message-ID: <20141122081931.GA31717@dcvr.yhbt.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ML-Name: ruby-core X-Mail-Count: 66409 Subject: [ruby-core:66409] Re: [ruby-trunk - Feature #8543] rb_iseq_load X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" billk@cts.com wrote: > But ultimately, the result of the manual bisect was: > > 66d247bcb50a29769ff940100223544c125521aa is the first bad commit > commit 66d247bcb50a29769ff940100223544c125521aa > Author: ko1 > Date: Tue Apr 24 09:20:42 2012 +0000 > > * compile.c: fix to output warning when the same literals > are available as a condition of same case clause. > And remove infomation ('#n') because we can find duplicated > condition with explicit line numbers. > [ruby-core:38343] [Ruby 1.9 - Bug #5068] > * test/ruby/test_syntax.rb: add a test for above. That was only one of the breakages :) Things have bitrotted a lot over the years. The following patch might be ready to commit to trunk: http://80x24.org/spew/m/rb_iseq_load_fix@v1.txt It's better than the complete breakage we have right now, so I might commit the above in a few days. The new test case I added should help (or force) other core committers to maintain iseq loading, though. There's no public API change in this version of my patch. The test cases are probably not complete, though. I am mainly interested in the feature because I'm working on another (in-core) optimization which may utilize this. I can definitely use some help thinking of better test cases since I don't believe I remember all of Ruby syntax :x