From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ruby-core-bounces@ruby-lang.org>
X-Original-To: poffice@blade.nagaokaut.ac.jp
Delivered-To: poffice@blade.nagaokaut.ac.jp
Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24])
	by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 14D8E17D4531
	for <poffice@blade.nagaokaut.ac.jp>; Sun, 24 Nov 2013 14:10:25 +0900 (JST)
Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201])
	by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 180C3B5D831
	for <poffice@blade.nagaokaut.ac.jp>; Sun, 24 Nov 2013 13:42:25 +0900 (JST)
Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1])
	by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 9BCB897A82C
	for <poffice@blade.nagaokaut.ac.jp>; Sun, 24 Nov 2013 13:42:26 +0900 (JST)
X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp
Received: from funfun.nagaokaut.ac.jp ([127.0.0.1])
	by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Q7BDS4Qs-Gtj for <poffice@blade.nagaokaut.ac.jp>;
	Sun, 24 Nov 2013 13:42:26 +0900 (JST)
Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100])
	by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 7B96397A826
	for <poffice@blade.nagaokaut.ac.jp>; Sun, 24 Nov 2013 13:42:26 +0900 (JST)
Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75])
	by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id E51EA95241B
	for <poffice@blade.nagaokaut.ac.jp>; Sun, 24 Nov 2013 13:42:24 +0900 (JST)
Received: from [221.186.184.76] (localhost [IPv6:::1])
	by neon.ruby-lang.org (Postfix) with ESMTP id ABC4D12072F;
	Sun, 24 Nov 2013 13:42:22 +0900 (JST)
X-Original-To: ruby-core@ruby-lang.org
Delivered-To: ruby-core@ruby-lang.org
Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64])
 by neon.ruby-lang.org (Postfix) with ESMTP id 0E8261206D0
 for <ruby-core@ruby-lang.org>; Sun, 24 Nov 2013 13:42:15 +0900 (JST)
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
 by dcvr.yhbt.net (Postfix) with ESMTP id B81BD44C1C0;
 Sun, 24 Nov 2013 04:42:12 +0000 (UTC)
Date: Sun, 24 Nov 2013 04:42:12 +0000
From: Eric Wong <normalperson@yhbt.net>
To: Ruby developers <ruby-core@ruby-lang.org>
Message-ID: <20131124044212.GA31833@dcvr.yhbt.net>
References: <redmine.issue-9145.20131124124225@ruby-lang.org>
 <redmine.journal-43126.20131124133007@ruby-lang.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <redmine.journal-43126.20131124133007@ruby-lang.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-ML-Name: ruby-core
X-Mail-Count: 58547
Subject: [ruby-core:58547] Re: [ruby-trunk - Feature #9145][Feedback]
 Queue#pop(true) return nil if empty instead of raising ThreadError
X-BeenThere: ruby-core@ruby-lang.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: Ruby developers <ruby-core@ruby-lang.org>
List-Id: Ruby developers <ruby-core.ruby-lang.org>
List-Unsubscribe: <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>, 
 <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
List-Post: <mailto:ruby-core@ruby-lang.org>
List-Help: <mailto:ruby-core-request@ruby-lang.org?subject=help>
List-Subscribe: <http://lists.ruby-lang.org/cgi-bin/mailman/listinfo/ruby-core>, 
 <mailto:ruby-core-request@ruby-lang.org?subject=subscribe>
Errors-To: ruby-core-bounces@ruby-lang.org
Sender: "ruby-core" <ruby-core-bounces@ruby-lang.org>

"Glass_saga (Masaki Matsushita)" <glass.saga@gmail.com> wrote:
> I think we can't change default behavior of Queue#pop(true) because some code expects ThreadError to be raised.
> However, it may be possible to introduce new keyword argument like following:
> 
> q = Queue.new
> while next_item = q.pop(true, exception: false) # it doesn't raise ThreadError and returns nil.
>   # do something
> end

+1 to that.  All non-blocking methods (I/O or not) should support
exception: false to avoid (expensive/noisy-on-$DEBUG=$true) exceptions.