rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / Atom feed
From: "Matthew M. Boedicker" <matthewm@boedicker.org>
To: rack-devel@googlegroups.com
Subject: changing etag in deflater middleware
Date: Thu, 8 Apr 2010 00:40:23 -0400	[thread overview]
Message-ID: <q2y109538ef1004072140w766c13c1m39eead1729036f6b@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

I wrote a middleware to change the etag in the deflater middleware if the
content encoding is changed because two representations should not have the
same etag. If etag is present it adds the content encoding to the end of it,
so if the ETag is previously set to "xxx" from Rack::ETag it becomes
"xxxgzip" if it gets gzipped.

Is this something that should be done inside Deflater?

It's a simple change but I had trouble getting the test code to pass along
an etag header. If there is any interest I can finish a patch to deflater or
submit it as a separate middleware.


-- 
To unsubscribe, reply using "remove me" as the subject.

[-- Attachment #2: Type: text/html, Size: 620 bytes --]

                 reply	other threads:[~2010-04-08  5:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://groups.google.com/group/rack-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=q2y109538ef1004072140w766c13c1m39eead1729036f6b@mail.gmail.com \
    --to=rack-devel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).