From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.204.72.79 with SMTP id l15cs561484bkj; Sun, 9 Aug 2009 00:50:43 -0700 (PDT) Received-SPF: pass (google.com: domain of grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com designates 10.220.99.18 as permitted sender) client-ip=10.220.99.18; Authentication-Results: mr.google.com; spf=pass (google.com: domain of grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com designates 10.220.99.18 as permitted sender) smtp.mail=grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com; dkim=pass header.i=grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com Received: from mr.google.com ([10.220.99.18]) by 10.220.99.18 with SMTP id s18mr6255995vcn.10.1249804241347 (num_hops = 1); Sun, 09 Aug 2009 00:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:received:x-sender:x-apparently-to :received:received:received-spf:authentication-results:received :dkim-signature:domainkey-signature:mime-version:received :in-reply-to:references:date:message-id:subject:from:to:content-type :content-transfer-encoding:reply-to:sender:precedence:x-google-loop :mailing-list:list-id:list-post:list-help:list-unsubscribe :x-beenthere-env:x-beenthere; bh=olFSqmB0ZqGHpm75FOuV/6kxdm1sbi2mwfGWcRzfktc=; b=s2uflpaVQAC0lBnBZqf+fpRHdIKNgMKcCUXwM9OQgWAmOBlztKEzWGxJOndsRZptb7 ANmELrdhd5XAXF9PKskCKMy5cg9ZFLZea4kf5gkVGupFVmR+rjXm2hwFedVReJk+gkAb CNRB7A6OEOPFDAld3NmgWw2lL0DMsUaC0/XSM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-sender:x-apparently-to:received-spf:authentication-results :dkim-signature:domainkey-signature:mime-version:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding:reply-to:sender:precedence:x-google-loop :mailing-list:list-id:list-post:list-help:list-unsubscribe :x-beenthere-env:x-beenthere; b=APVhgzOdtaAyryJ1nhfNc7f7blUpiJC/9Qf9aXzcy19dfVwgY7PZj7FlMtYD1v/7W0 T3mjMK9jL8ZxyPvFXWPHAFo5mSWY5DMEqiF1HOYJqzAsD1C2HzZE+w33TCFkZZ2wSn6U njh85r2eLMVXNwvlZ2AXsqJNkWSaK68bziD6A= Received: by 10.220.99.18 with SMTP id s18mr730200vcn.10.1249804240987; Sun, 09 Aug 2009 00:50:40 -0700 (PDT) Received: by 10.230.16.65 with SMTP id n1gr1566vba.0; Sun, 09 Aug 2009 00:50:28 -0700 (PDT) X-Sender: rtomayko@gmail.com X-Apparently-To: rack-devel@googlegroups.com Received: by 10.220.100.199 with SMTP id z7mr658460vcn.6.1249804227808; Sun, 09 Aug 2009 00:50:27 -0700 (PDT) Return-Path: Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.27]) by gmr-mx.google.com with ESMTP id 20si259328vws.3.2009.08.09.00.50.26; Sun, 09 Aug 2009 00:50:26 -0700 (PDT) Received-SPF: pass (google.com: domain of rtomayko@gmail.com designates 74.125.92.27 as permitted sender) client-ip=74.125.92.27; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of rtomayko@gmail.com designates 74.125.92.27 as permitted sender) smtp.mail=rtomayko@gmail.com; dkim=pass (test mode) header.i=@gmail.com Received: by qw-out-2122.google.com with SMTP id 3so962967qwe.41 for ; Sun, 09 Aug 2009 00:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to :content-type:content-transfer-encoding; bh=RLc1X6lV5tgGzoB3P6s3iVtY76/fSup+iKaIg0CpANA=; b=tMxf3Rb3nCogUYOc0AzNsTHzYxw9hH1SjSqAtFUPFvfPWXpz8MO4U6kffcg6JFgwVI iQMgADO1T9lyzm+t4VSduZGRQqOosTyAVGlz5QiBc+kmTJ321h6Lwm7GAmAXCBJ95pE8 LRafyo1AW0Yd55NcljuzQxdDmXB2iJ9S8fX1I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=da5uvg0BabSuHBwqPwZ7fxZFSSfmSZSVLEQN9OekTOYWG+i2VSSjY4L9l9a6gPDw4Y whJwovuDgRaDdPXuCxEzqe6sMguieJYN3xEyP2QYm+aG01ub6yXfsEqDC4Nq5XHQcFnp ojJCyBQdSXiD9y3CD2Me73l63MwmmvZL8kNNE= MIME-Version: 1.0 Received: by 10.224.54.144 with SMTP id q16mr2276239qag.260.1249804226636; Sun, 09 Aug 2009 00:50:26 -0700 (PDT) In-Reply-To: <1c5622660908041922l2ae9490cp98c81d63f83318d5@mail.gmail.com> References: <1c5622660908041922l2ae9490cp98c81d63f83318d5@mail.gmail.com> Date: Sun, 9 Aug 2009 00:50:26 -0700 Message-ID: Subject: Re: Rack 1.0.1 maintenance release From: Ryan Tomayko To: rack-devel@googlegroups.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Reply-To: rack-devel@googlegroups.com Sender: rack-devel@googlegroups.com Precedence: bulk X-Google-Loop: groups Mailing-List: list rack-devel@googlegroups.com; contact rack-devel+owner@googlegroups.com List-Id: List-Post: List-Help: List-Unsubscribe: , X-BeenThere-Env: rack-devel@googlegroups.com X-BeenThere: rack-devel@googlegroups.com On Tue, Aug 4, 2009 at 7:22 PM, Joshua Peek wrote: > > On Mon, Aug 3, 2009 at 5:25 PM, Christian > Neukirchen wrote: >>> I'd like to do a 1.0.1 maintenance soon of the rack-1.0 branch. Please >>> test your apps and frameworks on that branch. It should be a fully >>> compatible bug fix release. >> >> This is a good idea. =C2=A0When you consider it ready, I can write an >> announcement and do a formal release on Rubyforge and my servers. > > Rails 2.3 is all systems go w/ rack 1.0.1. > > Should wait on Ryan to test w/ Sinatra. Sorry. I'm way behind on ML/lighthouse duties. Sinatra looks good under the rack-1.0 branch. +1 for release. The Sinatra test suite fails like crazy under 1.9 due to this rack.input / external encoding Rack::Lint check: http://github.com/rack/rack/commit/851782648fbbb141b1b56b73d8efc99efcac1b27= #L0R240 The Sinatra test suite puts Rack::Lint in the middleware pipeline for every test, though. I don't think that's a common practice. It passes 100% when I remove that check. The issue seems to be with the way Rack::MockRequest wraps the :input string in an StringIO without any encoding work. Or, maybe we should be setting the encoding on the input string before passing it in. I should be able to work around this in Sinatra somehow. Thanks, Ryan