From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.25.143.21 with SMTP id r21csp276833lfd; Fri, 29 May 2015 07:09:48 -0700 (PDT) X-Received: by 10.68.68.203 with SMTP id y11mr15217196pbt.34.1432908587356; Fri, 29 May 2015 07:09:47 -0700 (PDT) Return-Path: Received: from mail-pa0-x23f.google.com (mail-pa0-x23f.google.com. [2607:f8b0:400e:c03::23f]) by mx.google.com with ESMTPS id nu8si5816228pdb.190.2015.05.29.07.09.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 May 2015 07:09:47 -0700 (PDT) Received-SPF: pass (google.com: domain of rack-devel+bncBDVZBRNGRYLRBKHGUGVQKGQEZ7RN44Y@googlegroups.com designates 2607:f8b0:400e:c03::23f as permitted sender) client-ip=2607:f8b0:400e:c03::23f; Authentication-Results: mx.google.com; spf=pass (google.com: domain of rack-devel+bncBDVZBRNGRYLRBKHGUGVQKGQEZ7RN44Y@googlegroups.com designates 2607:f8b0:400e:c03::23f as permitted sender) smtp.mail=rack-devel+bncBDVZBRNGRYLRBKHGUGVQKGQEZ7RN44Y@googlegroups.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Received: by mail-pa0-x23f.google.com with SMTP id lf10sf9577508pab.0; Fri, 29 May 2015 07:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-type:x-original-sender:reply-to:precedence :mailing-list:list-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe; bh=uOHgtmox4ut/eWHXDtVQSAC1rTfqQZOwGhIfmKOXT58=; b=YtYiq+Tbd0/dkZeDu8RFIkWWpQlscjJWK9zGByCNV2aUbsljzCan2xX6i89HAXU8yE Lx6gOarqgTMROllPFrBYco/khqHeeyjFM873fimXYd5+3B+YrtqRJjKrn81eK+FPN3GB 6ReTGVaQgvPfxEC5bmB3W3vmDbXqfMWZVk4W5oxP9v28K6mBfL25WtPFqpELT2erE+LK jf04HF3QSYj4TJW+20L5TxRByBOzZesqzpzQdKULjPE0A4OvmrBgBKWtN4fGnZvRGbpx flrzIVY+7KY0ux1WYhrxxZdUqJZdS4HdB/7KpUhwXpdicX9r/Mk2+BWFIGlANyfIio6W y3fw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-type:x-original-sender:reply-to:precedence :mailing-list:list-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe; bh=uOHgtmox4ut/eWHXDtVQSAC1rTfqQZOwGhIfmKOXT58=; b=skEbAHbrw+t1vH5JDE8ogsL26LAlr7FmlfTWIz72OKPPg/hb5eqa4Po3/FfTGhksJi wdkfj7nlYzUKqzMp1JzWp7M8l6qnNFoxUavgD+czjPFPaiwvPGK9Jmex8wRhNp0fL91s dWLjLkRURGGpt5pd8rFbFqXGGX+lbHWbQbst4P1VnuioTBodFx5hzNU9smdOIcu7xRaH V1rSFHW6IpFrM2GKIymMx2fYVWqXpxHtv0SwJXUusEFhwzZy9dp5fmRoaYBifvHaLO5S DDm39iePX7yvNBKvxOessda3/x88SVTVdhAA7DWiqyJI9KEbHYWGQck0cZJojYvj9NtI 46Uw== X-Received: by 10.140.21.200 with SMTP id 66mr118968qgl.31.1432908584672; Fri, 29 May 2015 07:09:44 -0700 (PDT) X-BeenThere: rack-devel@googlegroups.com Received: by 10.140.22.175 with SMTP id 44ls1197295qgn.79.gmail; Fri, 29 May 2015 07:09:44 -0700 (PDT) X-Received: by 10.140.96.137 with SMTP id k9mr118369qge.10.1432908584189; Fri, 29 May 2015 07:09:44 -0700 (PDT) Date: Fri, 29 May 2015 07:09:43 -0700 (PDT) From: Hongli Lai To: rack-devel@googlegroups.com Cc: e@80x24.org Message-Id: In-Reply-To: <20150417204337.GA8711@dcvr.yhbt.net> References: <6816caae-e47e-4e9d-9897-70c2069200a0@googlegroups.com> <20150417204337.GA8711@dcvr.yhbt.net> Subject: Re: Close body object after socket hijacking or not? MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_700_1315088935.1432908583707" X-Original-Sender: honglilai@gmail.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: X-Google-Group-Id: 486215384060 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , ------=_Part_700_1315088935.1432908583707 Content-Type: multipart/alternative; boundary="----=_Part_701_798035621.1432908583707" ------=_Part_701_798035621.1432908583707 Content-Type: text/plain; charset=UTF-8 On Friday, April 17, 2015 at 10:43:38 PM UTC+2, Eric Wong wrote: > > I would like clarication on this issue, too. Ping? > No clarification has appeared. But as far as I'm concerned, closing the body anyway is the best thing to do. Rack::Lock is currently broken if we *don't* close the body upon hijacking, and there seems to be no alternative. I'll modify Passenger to follow this behavior. Starting from version 5.0.9, Passenger will also close the body upon hijacking, just like Puma and Thin. -- --- You received this message because you are subscribed to the Google Groups "Rack Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. ------=_Part_701_798035621.1432908583707 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Friday, April 17, 2015 at 10:43:38 PM UTC+2, Eric Wong = wrote:
I would like clarication= on this issue, too.  Ping?

No clarification has appeared. But as = far as I'm concerned, closing the body anyway is the best thing to do. Rack= ::Lock is currently broken if we *don't* close the body upon hijacking, and= there seems to be no alternative. I'll modify Passenger to follow this beh= avior. Starting from version 5.0.9, Passenger will also close the body upon= hijacking, just like Puma and Thin.

--

---
You received this message because you are subscribed to the Google Groups &= quot;Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to rack-dev= el+unsubscribe@googlegroups.com.
For more options, visit http= s://groups.google.com/d/optout.
------=_Part_701_798035621.1432908583707-- ------=_Part_700_1315088935.1432908583707--