From: Hongli Lai <honglilai@gmail.com>
To: rack-devel@googlegroups.com
Cc: e@80x24.org
Subject: Re: Close body object after socket hijacking or not?
Date: Fri, 29 May 2015 07:09:43 -0700 (PDT) [thread overview]
Message-ID: <f121aeba-4633-4cf0-8f45-a5998f3fd6eb@googlegroups.com> (raw)
In-Reply-To: <20150417204337.GA8711@dcvr.yhbt.net>
[-- Attachment #1.1: Type: text/plain, Size: 800 bytes --]
On Friday, April 17, 2015 at 10:43:38 PM UTC+2, Eric Wong wrote:
>
> I would like clarication on this issue, too. Ping?
>
No clarification has appeared. But as far as I'm concerned, closing the
body anyway is the best thing to do. Rack::Lock is currently broken if we
*don't* close the body upon hijacking, and there seems to be no
alternative. I'll modify Passenger to follow this behavior. Starting from
version 5.0.9, Passenger will also close the body upon hijacking, just like
Puma and Thin.
--
---
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #1.2: Type: text/html, Size: 1147 bytes --]
next prev parent reply other threads:[~2015-05-29 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 21:26 Close body object after socket hijacking or not? Hongli Lai
2015-04-17 20:43 ` Eric Wong
2015-05-29 14:09 ` Hongli Lai [this message]
2015-06-04 2:11 ` Eric Wong
2015-06-04 6:53 ` Hongli Lai
2015-06-04 12:38 ` Marc-André Cournoyer
2015-06-28 20:46 ` James Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f121aeba-4633-4cf0-8f45-a5998f3fd6eb@googlegroups.com \
--to=rack-devel@googlegroups.com \
--cc=e@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).