From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.140.141.15 with SMTP id o15cs555557rvd; Wed, 20 Jan 2010 10:10:30 -0800 (PST) Received: from mr.google.com ([10.101.141.11]) by 10.101.141.11 with SMTP id t11mr478595ann.12.1264011029523 (num_hops = 1); Wed, 20 Jan 2010 10:10:29 -0800 (PST) Received: by 10.101.141.11 with SMTP id t11mr29018ann.12.1264011027831; Wed, 20 Jan 2010 10:10:27 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.213.3.206 with SMTP id 14ls918189ebo.0.p; Wed, 20 Jan 2010 10:10:26 -0800 (PST) Received: by 10.213.110.17 with SMTP id l17mr43644ebp.11.1264011026301; Wed, 20 Jan 2010 10:10:26 -0800 (PST) Received: by 10.213.110.17 with SMTP id l17mr43643ebp.11.1264011026279; Wed, 20 Jan 2010 10:10:26 -0800 (PST) Return-Path: Received: from mail-ew0-f218.google.com (mail-ew0-f218.google.com [209.85.219.218]) by gmr-mx.google.com with ESMTP id 11si14850ewy.5.2010.01.20.10.10.25; Wed, 20 Jan 2010 10:10:25 -0800 (PST) Received-SPF: pass (google.com: domain of nicksieger@gmail.com designates 209.85.219.218 as permitted sender) client-ip=209.85.219.218; Received: by ewy10 with SMTP id 10so1064109ewy.15 for ; Wed, 20 Jan 2010 10:10:25 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.88.6 with SMTP id z6mr120181wee.52.1264011025106; Wed, 20 Jan 2010 10:10:25 -0800 (PST) In-Reply-To: References: <20100119232322.GA14249@dcvr.yhbt.net> Date: Wed, 20 Jan 2010 12:10:24 -0600 Message-ID: Subject: =?UTF-8?Q?Re=3A_Friends_of_Rack_=E2=88=A9_Friends_of_JRuby_=28was_Re=3A_Ra?= =?UTF-8?Q?ck_test_spec=5Frack=5Fruntime_fails_on_JRuby_due_to_timing=29?= From: Nick Sieger To: rack-devel@googlegroups.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of nicksieger@gmail.com designates 209.85.219.218 as permitted sender) smtp.mail=nicksieger@gmail.com; dkim=pass (test mode) header.i=@gmail.com X-Original-Sender: nicksieger@gmail.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/200889b8e641f0f4 X-Message-Url: http://groups.google.com/group/rack-devel/msg/396e28c918359250 Sender: rack-devel@googlegroups.com List-Unsubscribe: , List-Subscribe: , Content-Type: multipart/mixed; boundary=0016e6d9746e24c65f047d9c8016 --0016e6d9746e24c65f047d9c8016 Content-Type: text/plain; charset=ISO-8859-1 On Wed, Jan 20, 2010 at 12:08 PM, Nick Sieger wrote: > On Tue, Jan 19, 2010 at 5:23 PM, Eric Wong wrote: >> Nick Sieger wrote: >>> Yeah, anyone seen that before? For some reason the logger on the ci >>> box doesn't include the severity level in the output by default. >>> >>> 1) Failure: >>> test_spec {Rack::Logger} 001 [logs to rack.errors](Rack::Logger) >>> [./test/spec_rack_logger.rb:18]: >>> <"Program started\nNothing to do!\n"> expected to be =~ >>> . >> >> Hi Nick, >> >> I mentioned this in <20091231012252.GB7600@dcvr.yhbt.net>. >> >> Running this test standalone works fine, so I suspect another test is >> clobbering the default Logger::Formatter somewhere... > > To see the failure, you need to install Camping and run the Camping > handler tests. The problem is Camping pulls in ActiveSupport, which > messes with Logger and overrides the default formatter. > > The attached patch fixes the tests to make them insensitive to logger format. Stupid gmail ignored my attachment, here's another try. /Nick --0016e6d9746e24c65f047d9c8016 Content-Type: application/octet-stream; name="0001-Make-logger-specs-insensitive-to-format-ActiveSup.patch" Content-Disposition: attachment; filename="0001-Make-logger-specs-insensitive-to-format-ActiveSup.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g4ofibbo0 RnJvbSBmM2JiNjk2Nzk3Zjk0N2MxNmIxMWYwNzVmMjUzNjU1MjlhOGYxOGZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIFNpZWdlciA8bmlja0BuaWNrc2llZ2VyLmNvbT4KRGF0 ZTogV2VkLCAyMCBKYW4gMjAxMCAxMTo1NjoyMSAtMDYwMApTdWJqZWN0OiBbUEFUQ0hdIE1ha2Ug bG9nZ2VyIHNwZWNzIGluc2Vuc2l0aXZlIHRvIGZvcm1hdCAtLSBBY3RpdmVTdXBwb3J0IChwdWxs ZWQgaW4gYnkgQ2FtcGluZykgbWVzc2VzIHdpdGggdGhlIGxvZ2dlciBmb3JtYXR0ZXIKCi0tLQog dGVzdC9zcGVjX3JhY2tfbG9nZ2VyLnJiIHwgICAgNCArKy0tCiAxIGZpbGVzIGNoYW5nZWQsIDIg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90ZXN0L3NwZWNfcmFj a19sb2dnZXIucmIgYi90ZXN0L3NwZWNfcmFja19sb2dnZXIucmIKaW5kZXggZDU1YjljNy4uMjAz MzAwNiAxMDA2NDQKLS0tIGEvdGVzdC9zcGVjX3JhY2tfbG9nZ2VyLnJiCisrKyBiL3Rlc3Qvc3Bl Y19yYWNrX2xvZ2dlci5yYgpAQCAtMTUsNyArMTUsNyBAQCBjb250ZXh0ICJSYWNrOjpMb2dnZXIi IGRvCiAKICAgICBlcnJvcnMgPSBTdHJpbmdJTy5uZXcKICAgICBSYWNrOjpMb2dnZXIubmV3KGFw cCkuY2FsbCh7J3JhY2suZXJyb3JzJyA9PiBlcnJvcnN9KQotICAgIGVycm9ycy5zdHJpbmcuc2hv dWxkLm1hdGNoICJJTkZPIC0tIDogUHJvZ3JhbSBzdGFydGVkIgotICAgIGVycm9ycy5zdHJpbmcu c2hvdWxkLm1hdGNoICJXQVJOIC0tIDogTm90aGluZyB0byBkbyIKKyAgICBlcnJvcnMuc3RyaW5n LnNob3VsZC5tYXRjaCAiUHJvZ3JhbSBzdGFydGVkIgorICAgIGVycm9ycy5zdHJpbmcuc2hvdWxk Lm1hdGNoICJOb3RoaW5nIHRvIGRvIgogICBlbmQKIGVuZAotLSAKMS41LjYKCg== --0016e6d9746e24c65f047d9c8016--