From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.140.141.15 with SMTP id o15cs555454rvd; Wed, 20 Jan 2010 10:08:57 -0800 (PST) Received: from mr.google.com ([10.100.211.1]) by 10.100.211.1 with SMTP id j1mr398017ang.56.1264010936711 (num_hops = 1); Wed, 20 Jan 2010 10:08:56 -0800 (PST) Received: by 10.100.211.1 with SMTP id j1mr23036ang.56.1264010935011; Wed, 20 Jan 2010 10:08:55 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.204.13.214 with SMTP id d22ls92168bka.0.p; Wed, 20 Jan 2010 10:08:53 -0800 (PST) Received: by 10.204.13.70 with SMTP id b6mr10975bka.17.1264010933202; Wed, 20 Jan 2010 10:08:53 -0800 (PST) Received: by 10.204.13.70 with SMTP id b6mr10974bka.17.1264010933159; Wed, 20 Jan 2010 10:08:53 -0800 (PST) Return-Path: Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.158]) by gmr-mx.google.com with ESMTP id 11si9795bwz.7.2010.01.20.10.08.52; Wed, 20 Jan 2010 10:08:52 -0800 (PST) Received-SPF: pass (google.com: domain of nicksieger@gmail.com designates 72.14.220.158 as permitted sender) client-ip=72.14.220.158; Received: by fg-out-1718.google.com with SMTP id 22so866010fge.8 for ; Wed, 20 Jan 2010 10:08:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.88.136 with SMTP id a8mr112929wef.77.1264010931945; Wed, 20 Jan 2010 10:08:51 -0800 (PST) In-Reply-To: <20100119232322.GA14249@dcvr.yhbt.net> References: <20100119232322.GA14249@dcvr.yhbt.net> Date: Wed, 20 Jan 2010 12:08:51 -0600 Message-ID: Subject: =?UTF-8?Q?Re=3A_Friends_of_Rack_=E2=88=A9_Friends_of_JRuby_=28was_Re=3A_Ra?= =?UTF-8?Q?ck_test_spec=5Frack=5Fruntime_fails_on_JRuby_due_to_timing=29?= From: Nick Sieger To: rack-devel@googlegroups.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of nicksieger@gmail.com designates 72.14.220.158 as permitted sender) smtp.mail=nicksieger@gmail.com; dkim=pass (test mode) header.i=@gmail.com X-Original-Sender: nicksieger@gmail.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/200889b8e641f0f4 X-Message-Url: http://groups.google.com/group/rack-devel/msg/70a9760b18c59dae Sender: rack-devel@googlegroups.com List-Unsubscribe: , List-Subscribe: , Content-Type: text/plain; charset=ISO-8859-1 On Tue, Jan 19, 2010 at 5:23 PM, Eric Wong wrote: > Nick Sieger wrote: >> Yeah, anyone seen that before? For some reason the logger on the ci >> box doesn't include the severity level in the output by default. >> >> 1) Failure: >> test_spec {Rack::Logger} 001 [logs to rack.errors](Rack::Logger) >> [./test/spec_rack_logger.rb:18]: >> <"Program started\nNothing to do!\n"> expected to be =~ >> . > > Hi Nick, > > I mentioned this in <20091231012252.GB7600@dcvr.yhbt.net>. > > Running this test standalone works fine, so I suspect another test is > clobbering the default Logger::Formatter somewhere... To see the failure, you need to install Camping and run the Camping handler tests. The problem is Camping pulls in ActiveSupport, which messes with Logger and overrides the default formatter. The attached patch fixes the tests to make them insensitive to logger format. /Nick