From: Nick Sieger <nicksieger@gmail.com>
To: rack-devel@googlegroups.com
Subject: Re: Friends of Rack ∩ Friends of JRuby (was Re: Rack test spec_rack_runtime fails on JRuby due to timing)
Date: Wed, 20 Jan 2010 12:08:51 -0600 [thread overview]
Message-ID: <f0b861391001201008q58b58bddj96f4bb25f3117046@mail.gmail.com> (raw)
In-Reply-To: <20100119232322.GA14249@dcvr.yhbt.net>
On Tue, Jan 19, 2010 at 5:23 PM, Eric Wong <normalperson@yhbt.net> wrote:
> Nick Sieger <nicksieger@gmail.com> wrote:
>> Yeah, anyone seen that before? For some reason the logger on the ci
>> box doesn't include the severity level in the output by default.
>>
>> 1) Failure:
>> test_spec {Rack::Logger} 001 [logs to rack.errors](Rack::Logger)
>> [./test/spec_rack_logger.rb:18]:
>> <"Program started\nNothing to do!\n"> expected to be =~
>> </INFO\ \-\-\ :\ Program\ started/>.
>
> Hi Nick,
>
> I mentioned this in <20091231012252.GB7600@dcvr.yhbt.net>.
>
> Running this test standalone works fine, so I suspect another test is
> clobbering the default Logger::Formatter somewhere...
To see the failure, you need to install Camping and run the Camping
handler tests. The problem is Camping pulls in ActiveSupport, which
messes with Logger and overrides the default formatter.
The attached patch fixes the tests to make them insensitive to logger format.
/Nick
next prev parent reply other threads:[~2010-01-20 18:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 6:42 Friends of Rack ∩ Friends of JRuby (was Re: Rack test spec_rack_runtime fails on JRuby due to timing) Ryan Tomayko
2010-01-18 17:28 ` Charles Oliver Nutter
2010-01-18 17:51 ` Joshua Peek
2010-01-18 21:04 ` Nick Sieger
2010-01-18 22:19 ` Charles Oliver Nutter
2010-01-19 5:43 ` Nick Sieger
2010-01-19 23:23 ` Eric Wong
2010-01-20 18:08 ` Nick Sieger [this message]
2010-01-20 18:10 ` Nick Sieger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0b861391001201008q58b58bddj96f4bb25f3117046@mail.gmail.com \
--to=rack-devel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).