From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.103.181.8 with SMTP id i8cs334264mup; Mon, 8 Mar 2010 06:43:58 -0800 (PST) Received-SPF: pass (google.com: domain of 3LA2VSwcLCho74038KI74038KI.2ECH02A-34L4B6EE6B46HEKFI.2EC@groups.bounces.google.com designates 10.220.107.4 as permitted sender) client-ip=10.220.107.4; Authentication-Results: mr.google.com; spf=pass (google.com: domain of 3LA2VSwcLCho74038KI74038KI.2ECH02A-34L4B6EE6B46HEKFI.2EC@groups.bounces.google.com designates 10.220.107.4 as permitted sender) smtp.mail=3LA2VSwcLCho74038KI74038KI.2ECH02A-34L4B6EE6B46HEKFI.2EC@groups.bounces.google.com; dkim=pass header.i=3LA2VSwcLCho74038KI74038KI.2ECH02A-34L4B6EE6B46HEKFI.2EC@groups.bounces.google.com Received: from mr.google.com ([10.220.107.4]) by 10.220.107.4 with SMTP id z4mr933563vco.40.1268059437838 (num_hops = 1); Mon, 08 Mar 2010 06:43:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to :x-original-authentication-results:x-original-sender:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :x-thread-url:x-message-url:sender:list-subscribe:list-unsubscribe :content-type:content-transfer-encoding; bh=FwJXZ5sz0Hbn0brgtlm4qMEt9WnGiZRKPM7x1r7GRCs=; b=2bMLYKIe6y/AOojEtV4IZ6eyi5CFfx8ofIbCxnYJjjoxapkAhEjsSmVUtPOQhI0m/a P9JqG1QH1wdP1xycHVRivUglN8neT8to8FwgSIGksST+XLOrwCHkVx+IAGr1HSBa/vTT VhE1nkxcewOUIqqSTP4cnrp/qX172IPPeZIb8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:mime-version:in-reply-to:references:from :date:message-id:subject:to:x-original-authentication-results :x-original-sender:reply-to:precedence:mailing-list:list-id :list-post:list-help:list-archive:x-thread-url:x-message-url:sender :list-subscribe:list-unsubscribe:content-type :content-transfer-encoding; b=zTgodK8aY2B9r6RuzPSnz3d5b6vwQANvrTQeqEdkNy0QsJqg9V5mWKjsg01sf9froX RXdM62FC9w0TuPYSrdunw1K73w1ktcRhNf/Sisg812CbPceUYz6CDmd8rFodzl3XppN1 85CZIp0kboT0zpOudzV2FapqHMFu3WdIASf4A= Received: by 10.220.107.4 with SMTP id z4mr102182vco.40.1268059436553; Mon, 08 Mar 2010 06:43:56 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.220.47.17 with SMTP id l17ls1417964vcf.5.p; Mon, 08 Mar 2010 06:43:55 -0800 (PST) Received: by 10.220.167.16 with SMTP id o16mr700721vcy.19.1268059435266; Mon, 08 Mar 2010 06:43:55 -0800 (PST) Received: by 10.220.167.16 with SMTP id o16mr700720vcy.19.1268059435245; Mon, 08 Mar 2010 06:43:55 -0800 (PST) Return-Path: Received: from mail-qy0-f191.google.com (mail-qy0-f191.google.com [209.85.221.191]) by gmr-mx.google.com with ESMTP id 31si4992320vws.0.2010.03.08.06.43.55; Mon, 08 Mar 2010 06:43:55 -0800 (PST) Received-SPF: pass (google.com: domain of headius@headius.com designates 209.85.221.191 as permitted sender) client-ip=209.85.221.191; Received: by mail-qy0-f191.google.com with SMTP id 29so6132533qyk.15 for ; Mon, 08 Mar 2010 06:43:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.224.118.206 with SMTP id w14mr2520210qaq.366.1268059433269; Mon, 08 Mar 2010 06:43:53 -0800 (PST) In-Reply-To: <80d93359-c1c2-4589-9db9-4ff53cf4f95b@b7g2000yqd.googlegroups.com> References: <20100306075548.GB6474@dcvr.yhbt.net> <44f3f951-889e-45ec-ae46-40a371329a9e@e1g2000yqh.googlegroups.com> <20100307235337.GA15381@dcvr.yhbt.net> <927006e5-332c-4e59-aca6-4963bdcbea2a@q16g2000yqq.googlegroups.com> <80d93359-c1c2-4589-9db9-4ff53cf4f95b@b7g2000yqd.googlegroups.com> From: Charles Oliver Nutter Date: Mon, 8 Mar 2010 08:43:33 -0600 Message-ID: Subject: Re: Not cleaning up tempfiles for multipart? To: rack-devel@googlegroups.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of headius@headius.com designates 209.85.221.191 as permitted sender) smtp.mail=headius@headius.com X-Original-Sender: headius@headius.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/6eb2bc7a1f8c072c X-Message-Url: http://groups.google.com/group/rack-devel/msg/bdafe48d6c2f9357 Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, Mar 8, 2010 at 5:30 AM, Hongli Lai wrote: > On Mar 8, 12:26=C2=A0pm, Hongli Lai wrote: >> Charles's middleware looks simple enough. I approve. > > Sorry. I mean Eric's. :) > > Another thing that you might want to keep in mind is that users might > File.rename() a certain Tempfile, in which case you will not want to > unlink it. For example suppose one uploads a large file to the web > server, I think there are web apps out there that will simply rename() > the tempfile to the storage directory and therefore avoid an expensive > copy operation. I don't think it should be specified behavior that a tempfile *ever* exists on disk. The mechanism of temporary storage for a large incoming post should be a black box. Consider systems that won't actually have a writable filesystem, like GAE; there, the "tempfile" data would be stored in memory or in BigTable. Rack should not require that large multipart posts or anything else require a filesystem, nor guarantee that they'll be on any filesystem that exists. - Charlie