From: Charles Oliver Nutter <headius@headius.com>
To: rack-devel@googlegroups.com
Subject: Re: Rack test spec_rack_runtime fails on JRuby due to timing
Date: Mon, 18 Jan 2010 11:17:52 -0600 [thread overview]
Message-ID: <f04d2211001180917v712813d5m2c1fecbc9b826492@mail.gmail.com> (raw)
In-Reply-To: <e064621a1001172259r67f70ec9h70b21e3ae1f6b17f@mail.gmail.com>
On Mon, Jan 18, 2010 at 12:59 AM, Christian Neukirchen
<chneukirchen@gmail.com> wrote:
> On Mon, Jan 18, 2010 at 7:38 AM, Ryan Tomayko <r@tomayko.com> wrote:
>> Perhaps changing the assertion to be:
>>
>> Float(response[1]['X-Runtime-All']).should >=
>> Float(response[1]['X-Runtime-App'])
>>
>> ... or removing the assertion entirely.
>
> ... or introducing/moving a second sleep.
I made the following change on my (temporary) rack fork, which helps
ensure the times are long enough to be measurable:
http://github.com/headius/rack/commit/fb0a7378852b678315b403eb2061da73b4478a37
It's a little hacky, but it works well enough. Timing tests are
obviously hard to get right in any case.
- Charlie
next prev parent reply other threads:[~2010-01-18 17:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 18:20 Rack test spec_rack_runtime fails on JRuby due to timing Charles Oliver Nutter
2010-01-18 6:38 ` Ryan Tomayko
2010-01-18 6:59 ` Christian Neukirchen
2010-01-18 17:17 ` Charles Oliver Nutter [this message]
2010-02-08 19:38 ` Ryan Tomayko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f04d2211001180917v712813d5m2c1fecbc9b826492@mail.gmail.com \
--to=rack-devel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).