From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.229.225.21 with SMTP id iq21cs177309qcb; Mon, 8 Nov 2010 15:00:51 -0800 (PST) Return-Path: Received-SPF: pass (google.com: domain of rack-devel+bncCI7j-tniEhChguLmBBoEw0jqGw@googlegroups.com designates 10.142.9.9 as permitted sender) client-ip=10.142.9.9; Authentication-Results: mr.google.com; spf=pass (google.com: domain of rack-devel+bncCI7j-tniEhChguLmBBoEw0jqGw@googlegroups.com designates 10.142.9.9 as permitted sender) smtp.mail=rack-devel+bncCI7j-tniEhChguLmBBoEw0jqGw@googlegroups.com; dkim=pass header.i=rack-devel+bncCI7j-tniEhChguLmBBoEw0jqGw@googlegroups.com Received: from mr.google.com ([10.142.9.9]) by 10.142.9.9 with SMTP id 9mr1728969wfi.12.1289257250676 (num_hops = 1); Mon, 08 Nov 2010 15:00:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:mime-version :received:received:date:in-reply-to:x-ip:references:user-agent :x-http-useragent:message-id:subject:from:to:x-original-sender :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe:content-type :content-transfer-encoding; bh=kaJKtAZKIh8VBk83X4XxlOJdzZYTLzor6gw5ht6D3ak=; b=6bwEUiqsjE4+s825O45GTfnwJXdY87ZmeBB60IJ+0yHlJs74so/+ALCnq0XHKHY3aW 4ISnpLf15Zc7G1lMbPuJ3hHpa3TVnIYtgdDnMEaYSfgi0I2QxNGUc2RJl8JTw373nJnx TS6YT2jQ07JsmnIzKPR9QrgGP/1gCT7x1MqC8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:mime-version:date:in-reply-to:x-ip:references :user-agent:x-http-useragent:message-id:subject:from:to :x-original-sender:reply-to:precedence:mailing-list:list-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-transfer-encoding; b=v19t6aGFJ4UBe5RvLY7//3tzutWJWQCPzwPpO6qfQCcGumLmHEcwGSlprPWhNUrFTa lYoraAzmfu0LSInHa9i8QcUGv8HsjgtxixGKmfFCXaj9zzlJ/fOJNzeRLWbjBxCWY8xz /uQvjgwPnkm673WZfb4M0f/Y2jxzQEl448Dv8= Received: by 10.142.9.9 with SMTP id 9mr346368wfi.12.1289257249083; Mon, 08 Nov 2010 15:00:49 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.142.78.15 with SMTP id a15ls8923879wfb.2.p; Mon, 08 Nov 2010 15:00:48 -0800 (PST) MIME-Version: 1.0 Received: by 10.142.149.20 with SMTP id w20mr349249wfd.17.1289257248299; Mon, 08 Nov 2010 15:00:48 -0800 (PST) Received: by v20g2000prl.googlegroups.com with HTTP; Mon, 8 Nov 2010 15:00:48 -0800 (PST) Date: Mon, 8 Nov 2010 15:00:48 -0800 (PST) In-Reply-To: <234F3B33-10DE-499B-A01B-80C574ABA000@gmail.com> X-IP: 80.1.212.72 References: <2bd5f0c4-e4ca-4141-b33f-61d8d674b4e3@y31g2000vbt.googlegroups.com> <234F3B33-10DE-499B-A01B-80C574ABA000@gmail.com> User-Agent: G2/1.0 X-HTTP-UserAgent: Mozilla/5.0 (X11; U; Linux x86_64; en-US) AppleWebKit/534.7 (KHTML, like Gecko) Chrome/7.0.517.44 Safari/534.7,gzip(gfe) Message-ID: Subject: Re: should Rack::Response delete Content-Length on status 204? From: Jerry West To: Rack Development X-Original-Sender: jerry.west@ntlworld.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sorry, noob here - do you mean chneukirchen/rack or your fork? On second thoughts, I'll do both, apologies for the duplication. On Nov 7, 10:09=A0pm, James Tucker wrote: > Yes I think so, could you open an issue on github or a ticket on lighthou= se? I will review soon. > > Thank you! > > On 10 Oct 2010, at 15:40, Jerry West wrote: > > > > > > > > > Rack::Response#finish deletes Content-Type from the header when status > > =3D=3D 204. > > > Should it not also delete Content-Length too? =A0Rack::Lint certainly > > thinks so. > > > And on that note should the code for #finish() not be > > > if Utils::STATUS_WITH_NO_ENTITY_BODY.include?(status.to_i) > > > rather than "if [204, 304].include?(status.to_i)" ... > > > Thanks, > > =A0Jerry