Failure in handler/scgi in 2,0.x

Failure in handler/scgi in 2,0.x

[pmc]

[-- Attachment #1.1: Type: text/plain, Size: 1671 bytes --]

Hi, 
after changing rack 1.6.4 to 2.0.3, i see the following error:

[ERR][80427] Handling client: no implicit conversion of Hash into String
/ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `initialize'
/ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `new'
/ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in 
`process_request'
/ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:235:in `read_header'
/ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:203:in `block in handle_client'


There was a change made to lib/rack/handler/scgi.rb with the number
8a7a142de07cc052f5046bfb17b903d467eb24f6

It seems to me that this change was slightly mistaken. Anyway, reverting 
this solves
my problem:

*** gems/rack-2.0.3/lib/rack/handler/scgi.rb.orig       Wed Jun 28 22:04:56 
2017
--- gems/rack-2.0.3/lib/rack/handler/scgi.rb    Wed Jun 28 22:06:10 2017
***************
*** 41,47 ****
          env[QUERY_STRING] ||= ""
          env[SCRIPT_NAME] = ""
  
!         rack_input = StringIO.new(input_body, encoding: Encoding::BINARY)
  
          env.update(
            RACK_VERSION      => Rack::VERSION,
--- 41,48 ----
          env[QUERY_STRING] ||= ""
          env[SCRIPT_NAME] = ""
  
!         rack_input = StringIO.new(input_body)
!         rack_input.set_encoding(Encoding::BINARY)
  
          env.update(
            RACK_VERSION      => Rack::VERSION,



-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #1.2: Type: text/html, Size: 18685 bytes --]

Re: Failure in handler/scgi in 2,0.x

[Aaron Patterson]

[-- Attachment #1: Type: text/plain, Size: 2267 bytes --]

Applied, thank you.  It will be in the next release.

> On Jun 28, 2017, at 1:12 PM, pmc@citylink.dinoex.sub.org wrote:
> 
> Hi, 
> after changing rack 1.6.4 to 2.0.3, i see the following error:
> 
> [ERR][80427] Handling client: no implicit conversion of Hash into String
> /ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `initialize'
> /ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `new'
> /ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `process_request'
> /ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:235:in `read_header'
> /ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:203:in `block in handle_client'
> 
> 
> There was a change made to lib/rack/handler/scgi.rb with the number
> 8a7a142de07cc052f5046bfb17b903d467eb24f6
> 
> It seems to me that this change was slightly mistaken. Anyway, reverting this solves
> my problem:
> 
> *** gems/rack-2.0.3/lib/rack/handler/scgi.rb.orig       Wed Jun 28 22:04:56 2017
> --- gems/rack-2.0.3/lib/rack/handler/scgi.rb    Wed Jun 28 22:06:10 2017
> ***************
> *** 41,47 ****
>           env[QUERY_STRING] ||= ""
>           env[SCRIPT_NAME] = ""
>   
> !         rack_input = StringIO.new(input_body, encoding: Encoding::BINARY)
>   
>           env.update(
>             RACK_VERSION      => Rack::VERSION,
> --- 41,48 ----
>           env[QUERY_STRING] ||= ""
>           env[SCRIPT_NAME] = ""
>   
> !         rack_input = StringIO.new(input_body)
> !         rack_input.set_encoding(Encoding::BINARY)
>   
>           env.update(
>             RACK_VERSION      => Rack::VERSION,
> 
> 
> 
> 
> -- 
> 
> --- 
> You received this message because you are subscribed to the Google Groups "Rack Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com <mailto:rack-devel+unsubscribe@googlegroups.com>.
> For more options, visit https://groups.google.com/d/optout <https://groups.google.com/d/optout>.

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: Type: text/html, Size: 19164 bytes --]

Re: Failure in handler/scgi in 2,0.x

[pmc]

[-- Attachment #1.1: Type: text/plain, Size: 331 bytes --]

Thats the way I love it. Thank You!

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #1.2: Type: text/html, Size: 521 bytes --]