rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / code / Atom feed
* Failure in handler/scgi in 2,0.x
@ 2017-06-28 20:12 pmc
  2017-06-28 20:22 ` Aaron Patterson
  0 siblings, 1 reply; 3+ messages in thread
From: pmc @ 2017-06-28 20:12 UTC (permalink / raw)
  To: Rack Development


[-- Attachment #1.1: Type: text/plain, Size: 1671 bytes --]

Hi, 
after changing rack 1.6.4 to 2.0.3, i see the following error:

[ERR][80427] Handling client: no implicit conversion of Hash into String
/ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `initialize'
/ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `new'
/ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in 
`process_request'
/ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:235:in `read_header'
/ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:203:in `block in handle_client'


There was a change made to lib/rack/handler/scgi.rb with the number
8a7a142de07cc052f5046bfb17b903d467eb24f6

It seems to me that this change was slightly mistaken. Anyway, reverting 
this solves
my problem:

*** gems/rack-2.0.3/lib/rack/handler/scgi.rb.orig       Wed Jun 28 22:04:56 
2017
--- gems/rack-2.0.3/lib/rack/handler/scgi.rb    Wed Jun 28 22:06:10 2017
***************
*** 41,47 ****
          env[QUERY_STRING] ||= ""
          env[SCRIPT_NAME] = ""
  
!         rack_input = StringIO.new(input_body, encoding: Encoding::BINARY)
  
          env.update(
            RACK_VERSION      => Rack::VERSION,
--- 41,48 ----
          env[QUERY_STRING] ||= ""
          env[SCRIPT_NAME] = ""
  
!         rack_input = StringIO.new(input_body)
!         rack_input.set_encoding(Encoding::BINARY)
  
          env.update(
            RACK_VERSION      => Rack::VERSION,



-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #1.2: Type: text/html, Size: 18685 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Failure in handler/scgi in 2,0.x
  2017-06-28 20:12 Failure in handler/scgi in 2,0.x pmc
@ 2017-06-28 20:22 ` Aaron Patterson
  2017-06-28 21:13   ` pmc
  0 siblings, 1 reply; 3+ messages in thread
From: Aaron Patterson @ 2017-06-28 20:22 UTC (permalink / raw)
  To: rack-devel

[-- Attachment #1: Type: text/plain, Size: 2267 bytes --]

Applied, thank you.  It will be in the next release.

> On Jun 28, 2017, at 1:12 PM, pmc@citylink.dinoex.sub.org wrote:
> 
> Hi, 
> after changing rack 1.6.4 to 2.0.3, i see the following error:
> 
> [ERR][80427] Handling client: no implicit conversion of Hash into String
> /ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `initialize'
> /ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `new'
> /ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `process_request'
> /ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:235:in `read_header'
> /ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:203:in `block in handle_client'
> 
> 
> There was a change made to lib/rack/handler/scgi.rb with the number
> 8a7a142de07cc052f5046bfb17b903d467eb24f6
> 
> It seems to me that this change was slightly mistaken. Anyway, reverting this solves
> my problem:
> 
> *** gems/rack-2.0.3/lib/rack/handler/scgi.rb.orig       Wed Jun 28 22:04:56 2017
> --- gems/rack-2.0.3/lib/rack/handler/scgi.rb    Wed Jun 28 22:06:10 2017
> ***************
> *** 41,47 ****
>           env[QUERY_STRING] ||= ""
>           env[SCRIPT_NAME] = ""
>   
> !         rack_input = StringIO.new(input_body, encoding: Encoding::BINARY)
>   
>           env.update(
>             RACK_VERSION      => Rack::VERSION,
> --- 41,48 ----
>           env[QUERY_STRING] ||= ""
>           env[SCRIPT_NAME] = ""
>   
> !         rack_input = StringIO.new(input_body)
> !         rack_input.set_encoding(Encoding::BINARY)
>   
>           env.update(
>             RACK_VERSION      => Rack::VERSION,
> 
> 
> 
> 
> -- 
> 
> --- 
> You received this message because you are subscribed to the Google Groups "Rack Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com <mailto:rack-devel+unsubscribe@googlegroups.com>.
> For more options, visit https://groups.google.com/d/optout <https://groups.google.com/d/optout>.

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: Type: text/html, Size: 19164 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Failure in handler/scgi in 2,0.x
  2017-06-28 20:22 ` Aaron Patterson
@ 2017-06-28 21:13   ` pmc
  0 siblings, 0 replies; 3+ messages in thread
From: pmc @ 2017-06-28 21:13 UTC (permalink / raw)
  To: Rack Development; +Cc: tenderlove


[-- Attachment #1.1: Type: text/plain, Size: 331 bytes --]

Thats the way I love it. Thank You!

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #1.2: Type: text/html, Size: 521 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-28 21:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-28 20:12 Failure in handler/scgi in 2,0.x pmc
2017-06-28 20:22 ` Aaron Patterson
2017-06-28 21:13   ` pmc

rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/rack-devel

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 rack-devel rack-devel/ https://public-inbox.org/rack-devel \
		rack-devel@googlegroups.com
	public-inbox-index rack-devel

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.rack.devel
	nntp://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.lang.ruby.rack.devel
	nntp://news.gmane.io/gmane.comp.lang.ruby.rack.devel
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/rack.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git