From mboxrd@z Thu Jan 1 00:00:00 1970 MIME-Version: 1.0 Received: by 10.86.99.8 with HTTP; Thu, 8 Oct 2009 04:31:44 -0700 (PDT) In-Reply-To: <3543b06a-1f03-4d00-aeb3-cd65cd0ab67e@o21g2000vbl.googlegroups.com> References: <3543b06a-1f03-4d00-aeb3-cd65cd0ab67e@o21g2000vbl.googlegroups.com> Date: Thu, 8 Oct 2009 13:31:44 +0200 Delivered-To: chneukirchen@gmail.com Message-ID: Subject: Re: [PATCH] Fix handling of multipart uploads where the filename includes a semicolon. From: Christian Neukirchen To: rack-devel@googlegroups.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Thu, Oct 8, 2009 at 9:00 AM, YoNoSoyTu wr= ote: > > Hello, > > Rack 1.0.0 and the current Rack master branch includes a bug when > parsing a multipart upload, where one =A0of the filenames include a > semicolon ";". Currently the filename get truncated at the semicolon. > The fix uses the regular expression used by Ruby cgi.rb to parse > correctly the filename parameter when it includes the semicolon. A > test case is also included. I think this looks good, comments? Should go to rack-1.0 as well. --=20 Christian Neukirchen http://chneukirchen.org