rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / code / Atom feed
* [PATCH] Fix handling of multipart uploads where the filename includes  a semicolon.
@ 2009-10-08  7:00 YoNoSoyTu
  2009-10-08 11:31 ` Christian Neukirchen
  0 siblings, 1 reply; 2+ messages in thread
From: YoNoSoyTu @ 2009-10-08  7:00 UTC (permalink / raw)
  To: Rack Development


Hello,

Rack 1.0.0 and the current Rack master branch includes a bug when
parsing a multipart upload, where one  of the filenames include a
semicolon ";". Currently the filename get truncated at the semicolon.
The fix uses the regular expression used by Ruby cgi.rb to parse
correctly the filename parameter when it includes the semicolon. A
test case is also included.

You can find the fix in my Github fork: <http://github.com/drodriguez/
rack/tree/fix_multipart_filename_parsing>. If you prefer a attached
patch file, or other format, please, let me know.

Regards,
Daniel Rodríguez Troitiño.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix handling of multipart uploads where the filename  includes a semicolon.
  2009-10-08  7:00 [PATCH] Fix handling of multipart uploads where the filename includes a semicolon YoNoSoyTu
@ 2009-10-08 11:31 ` Christian Neukirchen
  0 siblings, 0 replies; 2+ messages in thread
From: Christian Neukirchen @ 2009-10-08 11:31 UTC (permalink / raw)
  To: rack-devel

On Thu, Oct 8, 2009 at 9:00 AM, YoNoSoyTu <drodrigueztroitino@gmail.com> wrote:
>
> Hello,
>
> Rack 1.0.0 and the current Rack master branch includes a bug when
> parsing a multipart upload, where one  of the filenames include a
> semicolon ";". Currently the filename get truncated at the semicolon.
> The fix uses the regular expression used by Ruby cgi.rb to parse
> correctly the filename parameter when it includes the semicolon. A
> test case is also included.

I think this looks good, comments? Should go to rack-1.0 as well.

-- 
Christian Neukirchen  <chneukirchen@gmail.com>  http://chneukirchen.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-10-08 11:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-08  7:00 [PATCH] Fix handling of multipart uploads where the filename includes a semicolon YoNoSoyTu
2009-10-08 11:31 ` Christian Neukirchen

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/rack.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).