Re: Suggestion: Uppercase extensions should be downcased

[Lars Olsson <lasso@lassoweb.se>]

On 23 Juni, 15:45, Michael Fellinger <m.fellin...@gmail.com> wrote:
> On Sat, Jun 20, 2009 at 7:27 PM, Lars Olsson<la...@lassoweb.se> wrote:
>
> > Hello!
>
> > While working with some files created on Windows in Ramaze i discoved
> > that the web server returned the wrong content-type in some cases. I
> > tracked this down to the mime_type function in rack.
>
> > (from file rack/lib/rack/mime.rb)
> > def mime_type(ext, fallback='application/octet-stream')
> >    MIME_TYPES.fetch(ext, fallback)
> > end
>
> > This gives me trouble when the file extension includes uppercase letters
> > as nothing in MIME_TYPES is matching. I think the code should be changed to:
>
> > def mime_type(ext, fallback='application/octet-stream')
> >    MIME_TYPES.fetch(ext.downcase, fallback)
> > end
>
> > which makes extensions like .JPG work again.
>
> OK, pushed a patch for that.
>
> --
> ^ manveru

Thanks!

/lasso