rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / Atom feed
From: Niels Ganser <niels@herimedia.com>
To: rack-devel@googlegroups.com
Subject: Re: Tempfile#unlink changes in Ruby 1.9.1-p152
Date: Sun, 19 Jul 2009 01:43:27 +0200	[thread overview]
Message-ID: <be683e140907181643p7a61bd47g868c4011d9e5d5ed@mail.gmail.com> (raw)
In-Reply-To: <20090718222513.GA31002@dcvr.yhbt.net>


Eric,

2009/7/19 Eric Wong <normalperson@yhbt.net>
>
> Thanks for the heads up, I just posted my thoughts on Redmine about this.
> Hopefully the Ruby team is willing to fix it.

Thanks for putting this to their attention.

I've updated the issue with links to the original discussion on
ruby-core in 2004. Both the its author and matz decided the patch, as
recently introduced, wouldn't be a good idea:
http://blade.nagaokaut.ac.jp/cgi-bin/vframe.rb/ruby/ruby-core/2848?2697-2915+split-mode-vertical.

> If we have to go this route, what about just explicitly unlinking it?
> I'm not going to go as far as undefining the finalizer that Tempfile
> defines since the finalizer checks if the file exists before unlinking
> anyways.

I don't think any change in the rack codebase will be necessary as I
fully expect this to be fixed in Ruby before the next release.
Considering that many people are even still using 1.8 I don't think
too many compile from trunk or any other svn branch for that matter.
Those who do would probably check the list here when in trouble, no?

Cheers,
Niels

  reply	other threads:[~2009-07-19  0:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-18 19:33 Tempfile#unlink changes in Ruby 1.9.1-p152 Niels Ganser
2009-07-18 22:25 ` Eric Wong
2009-07-18 23:43   ` Niels Ganser [this message]
2009-07-22  7:53     ` Hongli Lai
2009-07-22 14:41       ` Niels Ganser
2009-08-08  5:49         ` Taylor luk
2009-08-12  5:13           ` Taylor luk
2009-08-17 17:27             ` Hongli Lai
2009-08-20 19:05               ` Hongli Lai
2009-08-20 21:26                 ` Jeremy Kemper
2009-08-21  0:23                   ` masayoshi takahashi
2009-08-21  9:09                     ` Hongli Lai
2009-08-25 15:32                       ` Hongli Lai
2009-08-26  8:10                         ` Hongli Lai
2009-09-02 18:52                           ` Niels
2009-08-15 19:47     ` Ryan Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://groups.google.com/group/rack-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be683e140907181643p7a61bd47g868c4011d9e5d5ed@mail.gmail.com \
    --to=rack-devel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).