From: Ivan Ukhov <uvsoft@gmail.com>
To: Rack Development <rack-devel@googlegroups.com>
Subject: BUG: cookies with expiration date
Date: Thu, 29 Oct 2009 13:15:46 -0700 (PDT) [thread overview]
Message-ID: <bd327055-9b3b-4821-a6a6-0e2ffc25016f@t11g2000prh.googlegroups.com> (raw)
Hi!
Please have a look at this line:
http://github.com/rack/rack/blob/663abfce9b71ab273c8adc0e76c233671bc43e1d/lib/rack/response.rb#L64
value[:expires].clone.gmtime.strftime("%a, %d-%b-%Y %H:%M:%S GMT")
My default system locale is ru_RU.UTF8, therefore this line produces
string with Russian letters. Browsers cant set expiration date in
Russian. FF sets session cookies, Safari doesnt set cookies at all.
Suppose this is a bug. Instead of strftime, rfc2822 should be used.
Thanks.
reply other threads:[~2009-10-29 22:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd327055-9b3b-4821-a6a6-0e2ffc25016f@t11g2000prh.googlegroups.com \
--to=rack-devel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).