From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.140.141.15 with SMTP id o15cs315558rvd; Sat, 16 Jan 2010 09:47:56 -0800 (PST) Received: from mr.google.com ([10.150.173.3]) by 10.150.173.3 with SMTP id v3mr977584ybe.28.1263664075627 (num_hops = 1); Sat, 16 Jan 2010 09:47:55 -0800 (PST) Received: by 10.150.173.3 with SMTP id v3mr49293ybe.28.1263664073946; Sat, 16 Jan 2010 09:47:53 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.150.39.12 with SMTP id m12ls407835ybm.2.p; Sat, 16 Jan 2010 09:47:51 -0800 (PST) Received: by 10.150.59.8 with SMTP id h8mr1508176yba.3.1263664071468; Sat, 16 Jan 2010 09:47:51 -0800 (PST) Received: by 10.150.59.8 with SMTP id h8mr1508175yba.3.1263664071426; Sat, 16 Jan 2010 09:47:51 -0800 (PST) Return-Path: Received: from mail-yw0-f170.google.com (mail-yw0-f170.google.com [209.85.211.170]) by gmr-mx.google.com with ESMTP id 18si247099yxe.4.2010.01.16.09.47.51; Sat, 16 Jan 2010 09:47:51 -0800 (PST) Received-SPF: pass (google.com: domain of gbuesing@gmail.com designates 209.85.211.170 as permitted sender) client-ip=209.85.211.170; Received: by mail-yw0-f170.google.com with SMTP id 42so721842ywh.28 for ; Sat, 16 Jan 2010 09:47:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.101.165.10 with SMTP id s10mr297996ano.19.1263664071369; Sat, 16 Jan 2010 09:47:51 -0800 (PST) Date: Sat, 16 Jan 2010 09:47:51 -0800 (PST) In-Reply-To: <201001161547.26915.ibc@aliax.net> X-IP: 64.81.227.173 References: <201001161438.53304.ibc@aliax.net> <9c00d3e01001160601l62bf274ay6b899ff141c10fec@mail.gmail.com> <201001161547.26915.ibc@aliax.net> User-Agent: G2/1.0 X-HTTP-UserAgent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_8; en-us) AppleWebKit/531.21.8 (KHTML, like Gecko) Version/4.0.4 Safari/531.21.10,gzip(gfe),gzip(gfe) Message-ID: Subject: Re: Potential Rack-Contrib contributions From: Geoff Buesing To: Rack Development X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of gbuesing@gmail.com designates 209.85.211.170 as permitted sender) smtp.mail=gbuesing@gmail.com X-Original-Sender: gbuesing@gmail.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/c034955ef1a34475 X-Message-Url: http://groups.google.com/group/rack-devel/msg/cc2ba4183c715685 Sender: rack-devel@googlegroups.com List-Unsubscribe: , List-Subscribe: , Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable @Ryan - thanks, I'll pull together patches. And I agree that Rackables::Get is to generic of a name; SimpleGetEndpoint is much better. Running with that idea, I'm thinking of going a bit more generic: Rack::SimpleEndpoint, with a verb requirement as an optional argument. @I=F1aki and @Michael - thanks for the case-sensitivity heads up, and the regex. I'll make sure to put in tests for these cases. Geoff On Jan 16, 8:47=A0am, I=F1aki Baz Castillo wrote: > El S=E1bado, 16 de Enero de 2010, Michael Fellinger escribi=F3: > > > > Well for sure we can assume that other Rack middlewwares and also our > > > Rack app would generate a simple inline header value. Then I would > > > rewrite the regex to this one (the ";" is important): > > > > =A0HAS_CHARSET =3D /;[\s\t]*charset[\s\t]*=3D[\s\t]*/i > > > "\t" =3D~ /\s/ > > # 0 > > means > > /;\s*charset\s*=3D\s*/i > > will be enough. > > Right, my fault, normally I use [ \t]* instead of [\s\t]* which makes no = sense > as \s includes space and tabulator. > > > Regarding the case of Content-Type in the header Hash, as long as it's > > an instance of HeaderHash, the case will not matter, we normalize it > > behind the scene. > > ok, that's why I said "in case 2 perhaps I'm wrong" :) > > Thanks a lot. > > -- > I=F1aki Baz Castillo