rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / code / Atom feed
* configurable trusted proxies?
@ 2016-01-30 15:40 S. Brent Faulkner
  2016-02-01  9:53 ` Eric Wong
  0 siblings, 1 reply; 3+ messages in thread
From: S. Brent Faulkner @ 2016-01-30 15:40 UTC (permalink / raw)
  To: Rack Development


[-- Attachment #1.1: Type: text/plain, Size: 490 bytes --]

Hi all... wondering if anyone is willing to review and/or discuss the idea 
of configurable trusted proxies for Rack 
? https://github.com/rack/rack/pull/1001

Thanks

--Brent

S. Brent Faulkner

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #1.2: Type: text/html, Size: 772 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: configurable trusted proxies?
  2016-01-30 15:40 configurable trusted proxies? S. Brent Faulkner
@ 2016-02-01  9:53 ` Eric Wong
  2016-02-02  2:00   ` S. Brent Faulkner
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Wong @ 2016-02-01  9:53 UTC (permalink / raw)
  To: rack-devel

"S. Brent Faulkner" <sbfaulkner@gmail.com> wrote:
> Hi all... wondering if anyone is willing to review and/or discuss the idea 
> of configurable trusted proxies for Rack 
> ? https://github.com/rack/rack/pull/1001

I'm not sure why you put the directive inside Rack::Utils
instead of Rack::Request where it is the only user.

I suspect there's Rack::Utils users who do not use Rack::Request.

Not sure if the extra Array creation and block invocation makes
a meaningful performance difference for anyone.

Otherwise I guess it's fine (not that I can merge your change).


Note: I reviewed by adding the following line to my .git/config
at the remote configured for git://github.com/rack/rack.git

	fetch = +refs/pull/*:refs/remotes/pull/*

Then "git fetch", and "git log -p --color-words pull/1001/head"
This was following commit 13397c7963b30f1d05e316d4de1930a6f81abf38
The "--color-words" switch made the test/spec_request.rb changes
much more readable.

(I don't use proprietary APIs or run JavaScript)

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: configurable trusted proxies?
  2016-02-01  9:53 ` Eric Wong
@ 2016-02-02  2:00   ` S. Brent Faulkner
  0 siblings, 0 replies; 3+ messages in thread
From: S. Brent Faulkner @ 2016-02-02  2:00 UTC (permalink / raw)
  To: Rack Development; +Cc: e


[-- Attachment #1.1: Type: text/plain, Size: 1989 bytes --]

On Monday, February 1, 2016 at 4:53:05 AM UTC-5, Eric Wong wrote:
>
> "S. Brent Faulkner" <sbfau...@gmail.com <javascript:>> wrote: 
> > Hi all... wondering if anyone is willing to review and/or discuss the 
> idea 
> > of configurable trusted proxies for Rack 
> > ? https://github.com/rack/rack/pull/1001 
>
> I'm not sure why you put the directive inside Rack::Utils 
> instead of Rack::Request where it is the only user. 
>
>
discussing the configuration in github :-) ... fwiw.. the only other 
configurable options I saw anywhere were in Utils, so I put this 
configuration there as well. Also, determining what was/wasn't a trusted 
proxy sort of felt like a "utility" activity (especially once the config 
was done there)

I suspect there's Rack::Utils users who do not use Rack::Request. 
>
> Not sure if the extra Array creation and block invocation makes 
> a meaningful performance difference for anyone. 
>
>
re: performance... I don't think so from my (adhoc) tests, and I've 
essentially borrowed how it's done in ActionDispatch::RemoteIp ... if this 
is viewed as a problem we can likely come up with an alternative

Otherwise I guess it's fine (not that I can merge your change). 
>
>
> Note: I reviewed by adding the following line to my .git/config 
> at the remote configured for git://github.com/rack/rack.git 
>
>         fetch = +refs/pull/*:refs/remotes/pull/* 
>
> Then "git fetch", and "git log -p --color-words pull/1001/head" 
> This was following commit 13397c7963b30f1d05e316d4de1930a6f81abf38 
> The "--color-words" switch made the test/spec_request.rb changes 
> much more readable. 
>
> (I don't use proprietary APIs or run JavaScript) 
>

Thanks for looking! 

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #1.2: Type: text/html, Size: 3959 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-02  2:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-30 15:40 configurable trusted proxies? S. Brent Faulkner
2016-02-01  9:53 ` Eric Wong
2016-02-02  2:00   ` S. Brent Faulkner

rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/rack-devel

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 rack-devel rack-devel/ https://public-inbox.org/rack-devel \
		rack-devel@googlegroups.com
	public-inbox-index rack-devel

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.rack.devel
	nntp://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.lang.ruby.rack.devel
	nntp://news.gmane.io/gmane.comp.lang.ruby.rack.devel
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/rack.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git