From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,RCVD_IN_DNSWL_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from mail-ua0-x240.google.com (mail-ua0-x240.google.com [IPv6:2607:f8b0:400c:c08::240]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2C3FC20285 for ; Wed, 28 Jun 2017 20:14:46 +0000 (UTC) Received: by mail-ua0-x240.google.com with SMTP id w19sf6495656uac.0 for ; Wed, 28 Jun 2017 13:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:date:from:to:message-id:subject:mime-version :x-original-sender:reply-to:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-subscribe:list-unsubscribe; bh=+948eAAUIzOIXAOFu4mRkzv7C8h+UVYTjE9ZFbHULNQ=; b=mYTK228z6mEHkV9zquGutwG6cRwl5GN/n7Rf8xpC3at2TmdBds9TK6QcC5Bgws8Cuh Qs7upZmmuF3cUIo/Ac154YiA8+I9gb9TiIkVmxqQtEG0TN7qIB54EslbZSW86h+FUMeP HaIzpDEo15h+QuMeiwspKRSYu/t3Trc0vMAmJQg9f3tfK71l+J8Ftd9DHZtPQoPCttFh X9eJzzRFpxe6JwJVmlutZPxe9VW7STK4RGqaeuEAXxxzkDI424TcGowCoCjWVx0k2NLg rqkuqYMEd5+i+UqDnXQV6Jz34LDKYY7yGqn+jwvoTXbUmR/gJg0TpDATjOPdtzD32peQ hkxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:date:from:to:message-id:subject :mime-version:x-original-sender:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:list-subscribe :list-unsubscribe; bh=+948eAAUIzOIXAOFu4mRkzv7C8h+UVYTjE9ZFbHULNQ=; b=Tn9eBW3kIrmFoGFJTDTHoMRLO9JAK1cQvKnNJvC15mG9xAgogq1kkJZY90ll3NZTTD AVLT5kZAx8sHaNjErxbIb/1dKrtDrPxfRi6CkdCjUVUEEpcwvInVVLklSafKMqDe+KkB TgM45a0BzIn8V+J/KTX5LdMLHrezsYhC2y5+t017YGifD/oicohPOk20+PKgsnIYDfnH hTCAqHBFJEkbl03Cvt7MTjKldTOs6a2VLlYADjS276c9YfTbijft28eEeKZwLqcf0gDO LWJr+9h0ubBTVsG7bw8hLJkeJFzs3n/Sl4sonlGYg4g+w7hLqaNt/aqXfqGcRggaslh+ DaCw== Sender: rack-devel@googlegroups.com X-Gm-Message-State: AKS2vOwMjsj/Bqrmk8L3hvp6bAYJykPvhPXqhHB24e3c+COQHK8vrpbT UTz9zzM0Q8T8og== X-Received: by 10.36.95.74 with SMTP id r71mr97957itb.2.1498680885470; Wed, 28 Jun 2017 13:14:45 -0700 (PDT) X-BeenThere: rack-devel@googlegroups.com Received: by 10.36.25.133 with SMTP id b127ls3121751itb.12.gmail; Wed, 28 Jun 2017 13:14:44 -0700 (PDT) X-Received: by 10.200.48.149 with SMTP id v21mr7309139qta.22.1498680884926; Wed, 28 Jun 2017 13:14:44 -0700 (PDT) Received: by 10.202.74.148 with SMTP id x142msoia; Wed, 28 Jun 2017 13:12:35 -0700 (PDT) X-Received: by 10.36.71.10 with SMTP id t10mr236288itb.5.1498680754795; Wed, 28 Jun 2017 13:12:34 -0700 (PDT) Date: Wed, 28 Jun 2017 13:12:34 -0700 (PDT) From: pmc@citylink.dinoex.sub.org To: Rack Development Message-Id: Subject: Failure in handler/scgi in 2,0.x MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_3038_453488882.1498680754574" X-Original-Sender: pmc@citylink.dinoex.sub.org Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: X-Google-Group-Id: 486215384060 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , ------=_Part_3038_453488882.1498680754574 Content-Type: multipart/alternative; boundary="----=_Part_3039_1024851960.1498680754575" ------=_Part_3039_1024851960.1498680754575 Content-Type: text/plain; charset="UTF-8" Hi, after changing rack 1.6.4 to 2.0.3, i see the following error: [ERR][80427] Handling client: no implicit conversion of Hash into String /ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `initialize' /ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `new' /ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `process_request' /ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:235:in `read_header' /ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:203:in `block in handle_client' There was a change made to lib/rack/handler/scgi.rb with the number 8a7a142de07cc052f5046bfb17b903d467eb24f6 It seems to me that this change was slightly mistaken. Anyway, reverting this solves my problem: *** gems/rack-2.0.3/lib/rack/handler/scgi.rb.orig Wed Jun 28 22:04:56 2017 --- gems/rack-2.0.3/lib/rack/handler/scgi.rb Wed Jun 28 22:06:10 2017 *************** *** 41,47 **** env[QUERY_STRING] ||= "" env[SCRIPT_NAME] = "" ! rack_input = StringIO.new(input_body, encoding: Encoding::BINARY) env.update( RACK_VERSION => Rack::VERSION, --- 41,48 ---- env[QUERY_STRING] ||= "" env[SCRIPT_NAME] = "" ! rack_input = StringIO.new(input_body) ! rack_input.set_encoding(Encoding::BINARY) env.update( RACK_VERSION => Rack::VERSION, -- --- You received this message because you are subscribed to the Google Groups "Rack Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. ------=_Part_3039_1024851960.1498680754575 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,
after changing rack 1.6.4 to 2.0.3, i see the foll= owing error:

<= div class=3D"subprettyprint">[ERR][80427= ] Handling client: no = implicit c= onversion of Hash into<= span style=3D"color: #000;" class=3D"styled-by-prettify"> String
/ext/gems/= 2.3/gems/rack-2.0.1/lib= /rack
/handler/scgi.rb:44= :in `initialize'
/ext/gems/2.3/ge= ms/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `
new'
/ext/gems/2.3/gems/rack-2.0.1/lib/rac= k/handler/scgi.rb:44:in `process_request'

/ext/gems/<= /span>2.3<= span style=3D"color: #660;" class=3D"styled-by-prettify">/gems/scgi-0.9.1/lib/scgi.rb:235:in
`read_header'
/= ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:203:in `block in handle_client'


There= was a change made to lib/rack/handler/scgi.rb with the number
8a7a142de07cc052f5046bfb17b903d467eb24f6

It seems to me th= at this change was slightly mistaken. Anyway, reverting this solves
my p= roblem:

*** gems/rack-2.0.3/lib/rack/handler/scgi.rb<= /span>.orig =C2=A0 =C2=A0 = =C2=A0 Wed= Jun 28 22:04:= 56<= span style=3D"color: #000;" class=3D"styled-by-prettify"> 2017
--- gems/rack-= 2.0.3/lib/rack/handler/sc= gi.= rb =C2=A0 =C2=A0<= /span>Wed<= span style=3D"color: #000;" class=3D"styled-by-prettify"> Jun 28 22:06= :10 2017
***************
*** 41,47 ****
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 env
[QUERY= _STRING] ||=3D ""
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 env
= [SCRIPT_NA= ME]= =3D ""
=C2=A0
! =C2=A0 =C2=A0 =C2=A0 =C2=A0 rack_input =3D StringIO.new(input_body, encoding: Enco= ding::BINARY<= span style=3D"color: #660;" class=3D"styled-by-prettify">)
=C2=A0
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 env
.update(
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RACK_VERSION =C2=A0 =C2=A0 =C2=A0=
=3D> Rack::VERSION,
--- 41,48 ----
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 env
= [QUERY_STR= ING] ||=3D ""
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 env
[SCRIPT_NAME<= /span>] =3D ""
=C2=A0
! =C2=A0 =C2=A0 =C2=A0 =C2=A0 rack_input =3D StringIO.new(input_body)
! =C2=A0 = =C2=A0 =C2=A0 =C2=A0 rack_input.set_encoding(Encoding::BINAR= Y)<= span style=3D"color: #000;" class=3D"styled-by-prettify">
=C2=A0
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 env
.update(
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RACK_VERSION =C2=A0 =C2=A0= =C2=A0
=3D= > Rack::VERSION,


--

---
You received this message because you are subscribed to the Google Groups &= quot;Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to rack-dev= el+unsubscribe@googlegroups.com.
For more options, visit http= s://groups.google.com/d/optout.
------=_Part_3039_1024851960.1498680754575-- ------=_Part_3038_453488882.1498680754574--