rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / code / Atom feed
* Failure in handler/scgi in 2,0.x
@ 2017-06-28 20:12 pmc
  2017-06-28 20:22 ` Aaron Patterson
  0 siblings, 1 reply; 3+ messages in thread
From: pmc @ 2017-06-28 20:12 UTC (permalink / raw)
  To: Rack Development


[-- Attachment #1.1: Type: text/plain, Size: 1671 bytes --]

Hi, 
after changing rack 1.6.4 to 2.0.3, i see the following error:

[ERR][80427] Handling client: no implicit conversion of Hash into String
/ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `initialize'
/ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `new'
/ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in 
`process_request'
/ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:235:in `read_header'
/ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:203:in `block in handle_client'


There was a change made to lib/rack/handler/scgi.rb with the number
8a7a142de07cc052f5046bfb17b903d467eb24f6

It seems to me that this change was slightly mistaken. Anyway, reverting 
this solves
my problem:

*** gems/rack-2.0.3/lib/rack/handler/scgi.rb.orig       Wed Jun 28 22:04:56 
2017
--- gems/rack-2.0.3/lib/rack/handler/scgi.rb    Wed Jun 28 22:06:10 2017
***************
*** 41,47 ****
          env[QUERY_STRING] ||= ""
          env[SCRIPT_NAME] = ""
  
!         rack_input = StringIO.new(input_body, encoding: Encoding::BINARY)
  
          env.update(
            RACK_VERSION      => Rack::VERSION,
--- 41,48 ----
          env[QUERY_STRING] ||= ""
          env[SCRIPT_NAME] = ""
  
!         rack_input = StringIO.new(input_body)
!         rack_input.set_encoding(Encoding::BINARY)
  
          env.update(
            RACK_VERSION      => Rack::VERSION,



-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #1.2: Type: text/html, Size: 18685 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-28 21:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-28 20:12 Failure in handler/scgi in 2,0.x pmc
2017-06-28 20:22 ` Aaron Patterson
2017-06-28 21:13   ` pmc

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/rack.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).