From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from mail-ua0-f190.google.com (mail-ua0-f190.google.com [209.85.217.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 894DC2023D for ; Wed, 28 Jun 2017 20:22:39 +0000 (UTC) Received: by mail-ua0-f190.google.com with SMTP id n31sf6424136uai.1 for ; Wed, 28 Jun 2017 13:22:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1498681358; cv=pass; d=google.com; s=arc-20160816; b=u0wKQgSfKWCqVgTS4IKQzdEg70W0eNTrf8hdHmgC9gW19ZVmlLJJntg2yBkFkvzOvT g0YiEwRjuieHbVrHobvl52J/qr65vtra+fmbs/SZtAf8w0nXVeKHuqL3Aj6AHMMustiQ dhvhyJ26tSJgYhhtjGfMHBOrOieWyCPUUUMGzGCWaU+suubvfZaY/GSCjE6qzftmMLbq e5iPg5K2mgOjDMoWQtOkWCypV5L1xLr6t92rpXF511IO/AShWhiNxhRtgXH/rA/gMJgc TYsVMFWS4nQYCCWm71Le0DKcD+EsSdq5sR3Q/vdbpwmP6j05GPzL4eoFkJcboW3EXfq/ xXqg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:message-id:in-reply-to:to :references:date:subject:mime-version:from:sender :arc-authentication-results:arc-message-signature :arc-authentication-results; bh=PJ0/8Zel6WFl1sg5WjQ2BNRaK4C1XMhvwUMPGRGySJs=; b=MMHB9ejIQKLuFUlOpww2iJIJCYZQ/LES1LwOGYHruXcUvP84TfWKn/yItxkceO21Tl j+FQgZ6ysPdjs0yG07vNRAsBO8ty61fwGg3yBPzBz2j3dmFxTd9jUGpsXkZpAI9uTpQq 0BY9AzkMaOcMnfc88zxQ8VQVEZdLH0b1Y9X7AOfkxkJOSdK5sPPJ7nOarAFDPDWxWcvg 4OAn/x3cRG+sH6jOLrlafGjAzbWajrX1SzN1w+3pLvn4OAKAHULBuyb3rvWW+z3MFBMy OfURdfamQThHDwRJx3bKBL6CJ5tXufRQpfT0EbEBSRgLNEx9vsFabAEp8Ump8KhQvBvV 0joQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@tenderlovemaking-com.20150623.gappssmtp.com header.b=s9DNcdUQ; spf=neutral (google.com: 2607:f8b0:400e:c05::242 is neither permitted nor denied by best guess record for domain of aaron@tenderlovemaking.com) smtp.mailfrom=aaron@tenderlovemaking.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:mime-version:subject:date:references :to:in-reply-to:message-id:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=PJ0/8Zel6WFl1sg5WjQ2BNRaK4C1XMhvwUMPGRGySJs=; b=amjsp+Xgp+wxthUejrXa6i1CRfvBsJiaaqd1KbgaNQzOtsaEsgQ6/mHjPbE0B1xSlc asuafBkfXw6nhmkE2yTbotjgecscIhAZocFQGf9QBc5bvJkV0wdazsZSuUHLAHSIZYbj WkTxuzyMulFQlyWWFjc3oM73KPwxuqEr2l4+wGaq/H59XQZX9E8KO8jufbapzvXUXfEr GXKjr8ElHXwlly9ccrNimdHdzRXW2fuET8zt7YesEKBmKFdfVzsqp8uR6Q+eVf84+XdY rQlRUUejxTV/xBG1M9I+zk0aeJc45ULVbF4tCXzSC4tSwYnTMuv6jqfFU8j8hUpZDhKJ 5lMw== X-Gm-Message-State: AKS2vOyM1jd2Q8lZXrFDDtAb4KNmYS5lHJj00wz+JcGPB0Lu7dAJS6T7 Bbdalg+1cQi1Zw== X-Received: by 10.36.34.209 with SMTP id o200mr236064ito.0.1498681358594; Wed, 28 Jun 2017 13:22:38 -0700 (PDT) X-BeenThere: rack-devel@googlegroups.com Received: by 10.36.41.199 with SMTP id p190ls3107161itp.17.canary-gmail; Wed, 28 Jun 2017 13:22:37 -0700 (PDT) X-Received: by 10.200.45.26 with SMTP id n26mr3593931qta.27.1498681357918; Wed, 28 Jun 2017 13:22:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498681357; cv=none; d=google.com; s=arc-20160816; b=PMOe5tRfizgLEh8izY+A0xlNoYzXUxTwVszDf1+vmiqQ6xmz+FcqB5KObPYDKYrmet WJEc230Cme4VvpadC74WkJFk0U0Hyiaw64umJPXEX2BVeTbk5R7BSeyM2qbppb9AKsnO 8dOeFAS1rdYzD8LkGIvLv2b4WV7lX2hE4KX6GRzor4F6nf4lsbaVXxELbeYljYvZqP/L 4tnkgZwBRInngl2CVBpI9/pgcJDtG7My5ZID2cHla90UCkHFuix+ryFJ9wSt+2FoRiDF jGvDJuBR1PoX/Bkq5gNkzX8COtvuMtfMIFTJNs5rtkbNBPo/Lu+tl2kUdrzXexvT6bRu SwXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:in-reply-to:to:references:date:subject:mime-version:from :sender:dkim-signature:arc-authentication-results; bh=bYQAJtOahvNQCqzUSun6RwA7WpXMcFbK7JQ8ZfTaFNM=; b=lQt1t2je9zxU8RpepySeccJ7CLLvBXQNF7YALwVEvo5umUYmrUMqkErq3RWKqC9ASd wrnHVaZ7yzvQt8DygvLAoH7G0+m/aVSa5UvayHT8TferhfHOm5ZB4tBOWC+sQMLRP4rV zQL3bpGVYBo8WMogPmLizLRWKVUh8Pb9tbuUX3HGAv5ll9JkcokXhUZDzsMmciQ5xSSz rePGHEbDnrt87BZgZAfTmPfbiMJCp823ZqFztyaR/TmxHPqTYmj+xZySYjMijznuUGpF MEnsjY7mL695DvHxNVQffIoGfufHCdtfY2vryLd6lEYcVWZ4prgpkk2JKKKeyK3P7hHg zXDA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@tenderlovemaking-com.20150623.gappssmtp.com header.b=s9DNcdUQ; spf=neutral (google.com: 2607:f8b0:400e:c05::242 is neither permitted nor denied by best guess record for domain of aaron@tenderlovemaking.com) smtp.mailfrom=aaron@tenderlovemaking.com Received: from mail-pg0-x242.google.com (mail-pg0-x242.google.com. [2607:f8b0:400e:c05::242]) by gmr-mx.google.com with ESMTPS id h3si717113pfh.9.2017.06.28.13.22.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jun 2017 13:22:37 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400e:c05::242 is neither permitted nor denied by best guess record for domain of aaron@tenderlovemaking.com) client-ip=2607:f8b0:400e:c05::242; Received: by mail-pg0-x242.google.com with SMTP id j186so9347412pge.1 for ; Wed, 28 Jun 2017 13:22:37 -0700 (PDT) X-Received: by 10.98.198.208 with SMTP id x77mr12839829pfk.229.1498681357166; Wed, 28 Jun 2017 13:22:37 -0700 (PDT) Received: from ?IPv6:2601:602:9901:3a39:512f:bf8b:de55:8374? ([2601:602:9901:3a39:512f:bf8b:de55:8374]) by smtp.gmail.com with ESMTPSA id t78sm5304627pfa.48.2017.06.28.13.22.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jun 2017 13:22:36 -0700 (PDT) Sender: Aaron Patterson From: Aaron Patterson Content-Type: multipart/alternative; boundary="Apple-Mail=_FABF3D4A-8FDC-4D45-858B-36CC67B9B485" Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: Failure in handler/scgi in 2,0.x Date: Wed, 28 Jun 2017 13:22:35 -0700 References: To: rack-devel@googlegroups.com In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3273) X-Original-Sender: aaron@tenderlovemaking.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@tenderlovemaking-com.20150623.gappssmtp.com header.b=s9DNcdUQ; spf=neutral (google.com: 2607:f8b0:400e:c05::242 is neither permitted nor denied by best guess record for domain of aaron@tenderlovemaking.com) smtp.mailfrom=aaron@tenderlovemaking.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: X-Google-Group-Id: 486215384060 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , --Apple-Mail=_FABF3D4A-8FDC-4D45-858B-36CC67B9B485 Content-Type: text/plain; charset="UTF-8" Applied, thank you. It will be in the next release. > On Jun 28, 2017, at 1:12 PM, pmc@citylink.dinoex.sub.org wrote: > > Hi, > after changing rack 1.6.4 to 2.0.3, i see the following error: > > [ERR][80427] Handling client: no implicit conversion of Hash into String > /ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `initialize' > /ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `new' > /ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `process_request' > /ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:235:in `read_header' > /ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:203:in `block in handle_client' > > > There was a change made to lib/rack/handler/scgi.rb with the number > 8a7a142de07cc052f5046bfb17b903d467eb24f6 > > It seems to me that this change was slightly mistaken. Anyway, reverting this solves > my problem: > > *** gems/rack-2.0.3/lib/rack/handler/scgi.rb.orig Wed Jun 28 22:04:56 2017 > --- gems/rack-2.0.3/lib/rack/handler/scgi.rb Wed Jun 28 22:06:10 2017 > *************** > *** 41,47 **** > env[QUERY_STRING] ||= "" > env[SCRIPT_NAME] = "" > > ! rack_input = StringIO.new(input_body, encoding: Encoding::BINARY) > > env.update( > RACK_VERSION => Rack::VERSION, > --- 41,48 ---- > env[QUERY_STRING] ||= "" > env[SCRIPT_NAME] = "" > > ! rack_input = StringIO.new(input_body) > ! rack_input.set_encoding(Encoding::BINARY) > > env.update( > RACK_VERSION => Rack::VERSION, > > > > > -- > > --- > You received this message because you are subscribed to the Google Groups "Rack Development" group. > To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com . > For more options, visit https://groups.google.com/d/optout . -- --- You received this message because you are subscribed to the Google Groups "Rack Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. --Apple-Mail=_FABF3D4A-8FDC-4D45-858B-36CC67B9B485 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="UTF-8" Applied, thank = you.  It will be in the next release.

On Jun 28, 2017, at= 1:12 PM, pmc@cit= ylink.dinoex.sub.org wrote:

Hi,
after chan= ging rack 1.6.4 to 2.0.3, i see the following error:

[= ERR][80427] Handling client: no implicit conversion= of Hash into String<= br class=3D"">/ext/gems/2.3/gems/rack-2.0.1/lib/rack/handle= r/<= span style=3D"" class=3D"styled-by-prettify">scgi.rb:44:in `initialize'
/ext/gems/2.3/gems= /rack-2.0.1/lib/rack/handler/scgi.rb:44:in `
new'
/ext/gems/2.3/gems/rack-2.0.1/li= b/rack/handler/scgi.rb:44:in `process_request'

/ext/gems/2.3/gems/scgi-
0.9.1/lib/scgi.rb:235= :in= `read_header'
/ext/gems/= 2.3/gems/scgi-0.9.1/lib/scgi.rb:203:in `
block in handl= e_client'<= /span>


There was a change m= ade to lib/rack/handler/scgi.rb with the number
8a7a142de07cc052f5046bfb17b903d467eb24f6

It seems to me that this change was slightly mistaken. Anyway, reverting= this solves
my problem:
<= span class=3D"float-right">
*** gems/rack-2.0.3/lib/rack/handler/scgi.rb.orig       Wed Jun= 28 22:04= :56 2017
--- gems= /rack-2.0.3/lib/rack/handler/scgi.rb    Wed Jun 28 22:06:10 2017
***************
*** 41,47 ****
          env
[QUERY_STRING] ||=3D ""
        &= nbsp; env
[= SCRIPT_NAME] =3D ""=
  =
!     &= nbsp;   rack_input =3D StringIO.new(input_body, encoding: Encoding::BINARY)
 
          = env
.update(
          &= nbsp; RACK_VERSION      
=3D> Rack:= :VERSION,
--- 41,= 48<= span style=3D"" class=3D"styled-by-prettify">
----
          env[QUERY_STRING] ||=3D ""
     = ;     env
[SCRIPT_NAME<= /span>] =3D ""
 
!   =       rack_input =3D Stri= ngIO.
new(input_body)
! &nbs= p;       rack_input.set_encoding(Enco= ding::BINARY)
 
   = ;       env
.updat= e(<= span style=3D"" class=3D"styled-by-prettify">
    &= nbsp;       RACK_VERSION      
=3D> Rack::= VERSION,




--

---
You received this message because you are subscribed to the Google Groups "= Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

---
You received this message because you are subscribed to the Google Groups &= quot;Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to rack-dev= el+unsubscribe@googlegroups.com.
For more options, visit http= s://groups.google.com/d/optout.
--Apple-Mail=_FABF3D4A-8FDC-4D45-858B-36CC67B9B485--