rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / code / Atom feed
From: Aaron Patterson <tenderlove@ruby-lang.org>
To: rack-devel@googlegroups.com
Subject: Re: Failure in handler/scgi in 2,0.x
Date: Wed, 28 Jun 2017 13:22:35 -0700	[thread overview]
Message-ID: <FFC2F28A-2425-452D-83B9-837FBD447C64@ruby-lang.org> (raw)
In-Reply-To: <a33c3e48-132c-476b-b3a1-2ff1028f12c6@googlegroups.com>

[-- Attachment #1: Type: text/plain, Size: 2267 bytes --]

Applied, thank you.  It will be in the next release.

> On Jun 28, 2017, at 1:12 PM, pmc@citylink.dinoex.sub.org wrote:
> 
> Hi, 
> after changing rack 1.6.4 to 2.0.3, i see the following error:
> 
> [ERR][80427] Handling client: no implicit conversion of Hash into String
> /ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `initialize'
> /ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `new'
> /ext/gems/2.3/gems/rack-2.0.1/lib/rack/handler/scgi.rb:44:in `process_request'
> /ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:235:in `read_header'
> /ext/gems/2.3/gems/scgi-0.9.1/lib/scgi.rb:203:in `block in handle_client'
> 
> 
> There was a change made to lib/rack/handler/scgi.rb with the number
> 8a7a142de07cc052f5046bfb17b903d467eb24f6
> 
> It seems to me that this change was slightly mistaken. Anyway, reverting this solves
> my problem:
> 
> *** gems/rack-2.0.3/lib/rack/handler/scgi.rb.orig       Wed Jun 28 22:04:56 2017
> --- gems/rack-2.0.3/lib/rack/handler/scgi.rb    Wed Jun 28 22:06:10 2017
> ***************
> *** 41,47 ****
>           env[QUERY_STRING] ||= ""
>           env[SCRIPT_NAME] = ""
>   
> !         rack_input = StringIO.new(input_body, encoding: Encoding::BINARY)
>   
>           env.update(
>             RACK_VERSION      => Rack::VERSION,
> --- 41,48 ----
>           env[QUERY_STRING] ||= ""
>           env[SCRIPT_NAME] = ""
>   
> !         rack_input = StringIO.new(input_body)
> !         rack_input.set_encoding(Encoding::BINARY)
>   
>           env.update(
>             RACK_VERSION      => Rack::VERSION,
> 
> 
> 
> 
> -- 
> 
> --- 
> You received this message because you are subscribed to the Google Groups "Rack Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com <mailto:rack-devel+unsubscribe@googlegroups.com>.
> For more options, visit https://groups.google.com/d/optout <https://groups.google.com/d/optout>.

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: Type: text/html, Size: 19164 bytes --]

  reply	other threads:[~2017-06-28 20:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 20:12 pmc
2017-06-28 20:22 ` Aaron Patterson [this message]
2017-06-28 21:13   ` pmc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://groups.google.com/group/rack-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FFC2F28A-2425-452D-83B9-837FBD447C64@ruby-lang.org \
    --to=rack-devel@googlegroups.com \
    --subject='Re: Failure in handler/scgi in 2,0.x' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/rack.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).