From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.49.85.105 with SMTP id g9csp20146qez; Sat, 26 Jan 2013 11:11:16 -0800 (PST) Return-Path: Received-SPF: pass (google.com: domain of rack-devel+bncBD75LW742ECRBU6USCEAKGQEO7PJLAQ@googlegroups.com designates 10.50.7.244 as permitted sender) client-ip=10.50.7.244 Authentication-Results: mr.google.com; spf=pass (google.com: domain of rack-devel+bncBD75LW742ECRBU6USCEAKGQEO7PJLAQ@googlegroups.com designates 10.50.7.244 as permitted sender) smtp.mail=rack-devel+bncBD75LW742ECRBU6USCEAKGQEO7PJLAQ@googlegroups.com; dkim=pass header.i=@googlegroups.com X-Received: from mr.google.com ([10.50.7.244]) by 10.50.7.244 with SMTP id m20mr1742085iga.14.1359227476206 (num_hops = 1); Sat, 26 Jan 2013 11:11:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf :x-received:mime-version:subject:from:in-reply-to:date:message-id :references:to:x-mailer:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=1MCfpKORYmLscBMOBWx9UCdxZQQjE+Pa5CVVhWyUjew=; b=dg0WosJDkQCvyMNXOST+E1PJKseamH1/ZVewYmwkeit4RMqc+BGrqIWU47B6B+969Z Ss0XqomMWOrbGoa73BQlDo8pKFSH2TaH5KgorQJBh7R5BtpX51gvsAaPrJ9pvkQQEWmS NObgvWL3hdzZZ2zfoZHhcS4jR32ixVtL8NYDfGnUW3EuD0WTlsfzGRndrea7uncG5ph4 LH88fyfg/bxl8yt2CYZemudglshpTGgfU3IuHcsrW/H0DoJByVfgqoLHvy3/p0yXZEjQ maYPdYW3CDpHcwY9NdL7XCtgBVQT0P3USe2hxPpvi8Z9MM2EojRcmbjJyEkFO820eR59 kZfA== X-Received: by 10.50.7.244 with SMTP id m20mr408465iga.14.1359227475960; Sat, 26 Jan 2013 11:11:15 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.50.242.71 with SMTP id wo7ls1102627igc.21.gmail; Sat, 26 Jan 2013 11:11:14 -0800 (PST) X-Received: by 10.66.86.129 with SMTP id p1mr1716177paz.24.1359227474747; Sat, 26 Jan 2013 11:11:14 -0800 (PST) X-Received: by 10.66.86.129 with SMTP id p1mr1716176paz.24.1359227474737; Sat, 26 Jan 2013 11:11:14 -0800 (PST) Received: from mail-pb0-f46.google.com (mail-pb0-f46.google.com [209.85.160.46]) by gmr-mx.google.com with ESMTPS id uz6si847129pbc.0.2013.01.26.11.11.14 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 26 Jan 2013 11:11:14 -0800 (PST) Received-SPF: pass (google.com: domain of jftucker@gmail.com designates 209.85.160.46 as permitted sender) client-ip=209.85.160.46; Received: by mail-pb0-f46.google.com with SMTP id mc17so127558pbc.33 for ; Sat, 26 Jan 2013 11:11:14 -0800 (PST) X-Received: by 10.68.219.227 with SMTP id pr3mr24526382pbc.38.1359227474652; Sat, 26 Jan 2013 11:11:14 -0800 (PST) Received: from [10.0.1.35] (c-67-180-21-214.hsd1.ca.comcast.net. [67.180.21.214]) by mx.google.com with ESMTPS id o6sm3290360paw.37.2013.01.26.11.11.12 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 26 Jan 2013 11:11:13 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\)) Subject: Re: [SEC][ANN] Rack 1.5.0, a modular Ruby webserver interface From: James Tucker In-Reply-To: <20130123002743.GA8819@dcvr.yhbt.net> Date: Sat, 26 Jan 2013 11:11:11 -0800 Message-Id: References: <50fe43c2.68dc440a.126d.ffffe987@mx.google.com> <20130122100802.GA28585@dcvr.yhbt.net> <20130123002743.GA8819@dcvr.yhbt.net> To: rack-devel@googlegroups.com X-Mailer: Apple Mail (2.1499) X-Original-Sender: jftucker@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jftucker@gmail.com designates 209.85.160.46 as permitted sender) smtp.mail=jftucker@gmail.com; dkim=pass header.i=@gmail.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: X-Google-Group-Id: 486215384060 List-Post: , List-Help: , List-Archive: Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=ISO-8859-1 On Jan 22, 2013, at 4:27 PM, Eric Wong wrote: > (culling Cc:) > > Eric Wong wrote: >> jftucker@gmail.com wrote: >>> Additonally, SPEC has been updated in several areas and is now at 1,2. >> >> SPEC still says this: >> >> rack.version:: The Array [1,1], representing this version of Rack. >> >> I take it 1,2-compliant servers should set [1,2] there instead? >> >>> A new SPEC section was introduced that provides two server-optional IO hijacking >>> APIs. Further information on these APIs will be made available by the community >>> in good time. In the mean time, some information can be found in the original >>> pull request: https://github.com/rack/rack/pull/481 > > So once a connection is hijacked, there's no un-hijacking, correct? > The server needs to completely ignore the normal Rack response > (I also just posted a Rack::Lint patch here to that effect) Correct. I don't see a way around this without making the specification excessively complex. That's why I strongly recommend people set Connection:close. > >> Cool. Should be easy for unicorn, and some configurations of >> Rainbows!/zbatery. > > I'm setting env["rack.version"] to [1,2] in my unicorn hijack branch. > Would greatly appreciate ACK/NACK on whether this is the way to go. Ack. I forgot to update lint - my bad. I'll fix this in .1. > > Original patch to implement hijack: > http://mid.gmane.org/20130122114943.GA8455@dcvr.yhbt.net Only had a quick scan, but LGTM. > > Followup to ignore responses for hijacked requests: > http://mid.gmane.org/20130122235728.GA8717@dcvr.yhbt.net --