rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / Atom feed
From: James Tucker <jftucker@gmail.com>
To: rack-devel@googlegroups.com
Subject: Re: [SEC][ANN] Rack 1.5.0, a modular Ruby webserver interface
Date: Sat, 26 Jan 2013 11:11:11 -0800	[thread overview]
Message-ID: <F550EB3A-5602-4CA6-87F6-B74197BFC525@gmail.com> (raw)
In-Reply-To: <20130123002743.GA8819@dcvr.yhbt.net>


On Jan 22, 2013, at 4:27 PM, Eric Wong <normalperson@yhbt.net> wrote:

> (culling Cc:)
> 
> Eric Wong <normalperson@yhbt.net> wrote:
>> jftucker@gmail.com wrote:
>>> Additonally, SPEC has been updated in several areas and is now at 1,2.
>> 
>> SPEC still says this:
>> 
>>  <tt>rack.version</tt>:: The Array [1,1], representing this version of Rack.
>> 
>> I take it 1,2-compliant servers should set [1,2] there instead?
>> 
>>> A new SPEC section was introduced that provides two server-optional IO hijacking
>>> APIs. Further information on these APIs will be made available by the community
>>> in good time. In the mean time, some information can be found in the original
>>> pull request: https://github.com/rack/rack/pull/481
> 
> So once a connection is hijacked, there's no un-hijacking, correct?
> The server needs to completely ignore the normal Rack response
> (I also just posted a Rack::Lint patch here to that effect)

Correct. I don't see a way around this without making the specification excessively complex. That's why I strongly recommend people set Connection:close.

> 
>> Cool.  Should be easy for unicorn, and some configurations of
>> Rainbows!/zbatery.
> 
> I'm setting env["rack.version"] to [1,2] in my unicorn hijack branch.
> Would greatly appreciate ACK/NACK on whether this is the way to go.

Ack. I forgot to update lint - my bad. I'll fix this in .1.

> 
> Original patch to implement hijack:
> http://mid.gmane.org/20130122114943.GA8455@dcvr.yhbt.net

Only had a quick scan, but LGTM.

> 
> Followup to ignore responses for hijacked requests:
> http://mid.gmane.org/20130122235728.GA8717@dcvr.yhbt.net

-- 

  parent reply	other threads:[~2013-01-26 19:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-22  7:46 [SEC][ANN] Rack 1.5.0, a modular Ruby webserver interface jftucker
2013-01-22  7:46 ` raggi
2013-01-22 10:08 ` Eric Wong
2013-01-23  0:27   ` Eric Wong
2013-01-23 22:40     ` Hongli Lai
2013-01-26 19:11     ` James Tucker [this message]
2013-01-22 18:14 ` Hongli Lai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://groups.google.com/group/rack-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F550EB3A-5602-4CA6-87F6-B74197BFC525@gmail.com \
    --to=rack-devel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).