From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.25.143.21 with SMTP id r21csp358521lfd; Wed, 3 Jun 2015 23:53:52 -0700 (PDT) X-Received: by 10.68.69.66 with SMTP id c2mr28759217pbu.169.1433400832261; Wed, 03 Jun 2015 23:53:52 -0700 (PDT) Return-Path: Received: from mail-pa0-x23a.google.com (mail-pa0-x23a.google.com. [2607:f8b0:400e:c03::23a]) by mx.google.com with ESMTPS id ck14si58795pdb.97.2015.06.03.23.53.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jun 2015 23:53:52 -0700 (PDT) Received-SPF: pass (google.com: domain of rack-devel+bncBDVZBRNGRYLRB7XLX6VQKGQEW7DO4NQ@googlegroups.com designates 2607:f8b0:400e:c03::23a as permitted sender) client-ip=2607:f8b0:400e:c03::23a; Authentication-Results: mx.google.com; spf=pass (google.com: domain of rack-devel+bncBDVZBRNGRYLRB7XLX6VQKGQEW7DO4NQ@googlegroups.com designates 2607:f8b0:400e:c03::23a as permitted sender) smtp.mail=rack-devel+bncBDVZBRNGRYLRB7XLX6VQKGQEW7DO4NQ@googlegroups.com; dkim=pass header.i=@googlegroups.com; dmarc=fail (p=NONE dis=NONE) header.from=gmail.com Received: by mail-pa0-x23a.google.com with SMTP id lj1sf752732pab.1; Wed, 03 Jun 2015 23:53:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe; bh=J3bXLra3nkAS+74qgMDCjveCsNbnngpCRrRPJJk2iHY=; b=MmTy5s0t0vQpBrHXxaCOIeoQ+8C6Eu2pvl5fLvRtTFsXjxZDxZUxrkrURWlrqFJ1Oz fYxnQd1penzv2LmMRNoUYvoCl8G8Wozl31dc/8DdiLmIilulN35PNQGHqtWnzlDM63Ie bqd1464zpXp2HKs2vwlQKrq9cRrqmCR/gbKfYfRhLOncMDKgc1GBybYFvTzQsUtGn86f nlq53XZkkoewasGwwtRiJhyN5GldNdJNbPuS8a7xDgPIl3lrcJru7yDCgALiYQk0TQpx T5Me7xI1esg8d2dzt5tclmSPUW4ytwCNThsQ32w0pBD6GdE6iO826xcX/9puig07MIVQ AkKA== X-Received: by 10.50.253.5 with SMTP id zw5mr48988igc.9.1433400830569; Wed, 03 Jun 2015 23:53:50 -0700 (PDT) X-BeenThere: rack-devel@googlegroups.com Received: by 10.107.136.167 with SMTP id s39ls367704ioi.88.gmail; Wed, 03 Jun 2015 23:53:49 -0700 (PDT) X-Received: by 10.66.63.102 with SMTP id f6mr46722142pas.19.1433400829844; Wed, 03 Jun 2015 23:53:49 -0700 (PDT) Received: from mail-pa0-x235.google.com (mail-pa0-x235.google.com. [2607:f8b0:400e:c03::235]) by gmr-mx.google.com with ESMTPS id fl5si335566pad.0.2015.06.03.23.53.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jun 2015 23:53:49 -0700 (PDT) Received-SPF: pass (google.com: domain of honglilai@gmail.com designates 2607:f8b0:400e:c03::235 as permitted sender) client-ip=2607:f8b0:400e:c03::235; Received: by payr10 with SMTP id r10so23483095pay.1 for ; Wed, 03 Jun 2015 23:53:49 -0700 (PDT) X-Received: by 10.66.184.133 with SMTP id eu5mr64824261pac.75.1433400829721; Wed, 03 Jun 2015 23:53:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.70.67.135 with HTTP; Wed, 3 Jun 2015 23:53:09 -0700 (PDT) In-Reply-To: <20150604021157.GA20396@dcvr.yhbt.net> References: <6816caae-e47e-4e9d-9897-70c2069200a0@googlegroups.com> <20150417204337.GA8711@dcvr.yhbt.net> <20150604021157.GA20396@dcvr.yhbt.net> From: Hongli Lai Date: Thu, 4 Jun 2015 08:53:09 +0200 Message-ID: Subject: Re: Close body object after socket hijacking or not? To: Eric Wong Cc: rack-devel@googlegroups.com, =?UTF-8?Q?Marc=2DAndr=C3=A9_Cournoyer?= Content-Type: text/plain; charset=UTF-8 X-Original-Sender: honglilai@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of honglilai@gmail.com designates 2607:f8b0:400e:c03::235 as permitted sender) smtp.mail=honglilai@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: X-Google-Group-Id: 486215384060 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Thu, Jun 4, 2015 at 4:11 AM, Eric Wong wrote: > Where does thin do this? I can see puma doing it, but it doesn't look > like thin supports hijack at all. > > git clone git://github.com/macournoyer/thin && cd thin && git grep -i hijack > You are right. It seems I am mistaken about this and got confused with another related aspect I was researching. I was researching https://github.com/ngauthier/tubesock/issues/10#issuecomment-72539461 and came to the conclusion that the bug doesn't occur in the same way on Thin, and somehow I got confused later on to conclude that Thin supports hijacking. -- --- You received this message because you are subscribed to the Google Groups "Rack Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.