Re: Close body object after socket hijacking or not?

[James Tucker <jftucker@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2406 bytes --]

Rack::Lock is a hack. Users wanting to operate with hijack should really
not be doing this under Rack::Lock.

Rack::Lock adds "server" (-like) semantics in the middle of the middleware
stack, and can break conventions required between the app and the server
for things like hijack.

Regarding the calling of close, yes, this should be done. Rack::Lock is the
most "visible" requirement to do this, but servers that support all of
HTTP/1.1 (i.e. pipelining) will require this. It should be noted that some
popular articles missed that this is what rack.hijack? is about, among
other things.

Sorry I missed this thread for so long, but I've been doing other things.
Implementors with questions should feel free to cc me directly if I'm not
picking up on stuff, I'll help where I can.

On Thu, Jun 4, 2015 at 5:38 AM Marc-André Cournoyer <macournoyer@gmail.com>
wrote:

> Indeed, no support for hijacking planned in Thin atm.
>
> On Thu, Jun 4, 2015 at 2:53 AM, Hongli Lai <honglilai@gmail.com> wrote:
>
>> On Thu, Jun 4, 2015 at 4:11 AM, Eric Wong <e@80x24.org> wrote:
>> > Where does thin do this?  I can see puma doing it, but it doesn't look
>> > like thin supports hijack at all.
>> >
>> > git clone git://github.com/macournoyer/thin && cd thin && git grep -i
>> hijack
>> > <no output from git grep>
>>
>> You are right. It seems I am mistaken about this and got confused with
>> another related aspect I was researching.
>>
>> I was researching
>> https://github.com/ngauthier/tubesock/issues/10#issuecomment-72539461
>> and came to the conclusion that the bug doesn't occur in the same way
>> on Thin, and somehow I got confused later on to conclude that Thin
>> supports hijacking.
>>
>
>
>
> --
> M-A
> http://macournoyer.com
>
>  --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Rack Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to rack-devel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: Type: text/html, Size: 3794 bytes --]