From: James Tucker <firstname.lastname@example.org> To: email@example.com, Hongli Lai <firstname.lastname@example.org> Cc: Eric Wong <email@example.com> Subject: Re: Close body object after socket hijacking or not? Date: Sun, 28 Jun 2015 20:46:46 +0000 [thread overview] Message-ID: <CABGa_T8fp-sGMRydLpcQPW2r+wHQ8RHPXnmcQsWyTUL4+Gc3+A@mail.gmail.com> (raw) In-Reply-To: <CACkZu0rzACsz753yQnf4oEmtsBB=3ZRssOMUFUXtBj09ezCdfirstname.lastname@example.org> [-- Attachment #1: Type: text/plain, Size: 2406 bytes --] Rack::Lock is a hack. Users wanting to operate with hijack should really not be doing this under Rack::Lock. Rack::Lock adds "server" (-like) semantics in the middle of the middleware stack, and can break conventions required between the app and the server for things like hijack. Regarding the calling of close, yes, this should be done. Rack::Lock is the most "visible" requirement to do this, but servers that support all of HTTP/1.1 (i.e. pipelining) will require this. It should be noted that some popular articles missed that this is what rack.hijack? is about, among other things. Sorry I missed this thread for so long, but I've been doing other things. Implementors with questions should feel free to cc me directly if I'm not picking up on stuff, I'll help where I can. On Thu, Jun 4, 2015 at 5:38 AM Marc-André Cournoyer <email@example.com> wrote: > Indeed, no support for hijacking planned in Thin atm. > > On Thu, Jun 4, 2015 at 2:53 AM, Hongli Lai <firstname.lastname@example.org> wrote: > >> On Thu, Jun 4, 2015 at 4:11 AM, Eric Wong <email@example.com> wrote: >> > Where does thin do this? I can see puma doing it, but it doesn't look >> > like thin supports hijack at all. >> > >> > git clone git://github.com/macournoyer/thin && cd thin && git grep -i >> hijack >> > <no output from git grep> >> >> You are right. It seems I am mistaken about this and got confused with >> another related aspect I was researching. >> >> I was researching >> https://github.com/ngauthier/tubesock/issues/10#issuecomment-72539461 >> and came to the conclusion that the bug doesn't occur in the same way >> on Thin, and somehow I got confused later on to conclude that Thin >> supports hijacking. >> > > > > -- > M-A > http://macournoyer.com > > -- > > --- > You received this message because you are subscribed to the Google Groups > "Rack Development" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to firstname.lastname@example.org. > For more options, visit https://groups.google.com/d/optout. > -- --- You received this message because you are subscribed to the Google Groups "Rack Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to email@example.com. For more options, visit https://groups.google.com/d/optout. [-- Attachment #2: Type: text/html, Size: 3794 bytes --]
prev parent reply other threads:[~2015-06-28 20:46 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-02-02 21:26 Hongli Lai 2015-04-17 20:43 ` Eric Wong 2015-05-29 14:09 ` Hongli Lai 2015-06-04 2:11 ` Eric Wong 2015-06-04 6:53 ` Hongli Lai 2015-06-04 12:38 ` Marc-André Cournoyer 2015-06-28 20:46 ` James Tucker [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-list from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://groups.google.com/group/rack-devel * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CABGa_T8fp-sGMRydLpcQPW2r+wHQ8RHPXnmcQsWyTUL4+Gc3+A@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: Close body object after socket hijacking or not?' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/rack.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).