rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / Atom feed
From: James Tucker <jftucker@gmail.com>
To: Rack Development <rack-devel@googlegroups.com>
Subject: Re: HTTP_ Headers from clients
Date: Mon, 24 Oct 2016 08:32:47 -0700	[thread overview]
Message-ID: <CABGa_T8YajQQT99UKBqSG51ube32EiQusc5aJRX=Z8A-kwkBCw@mail.gmail.com> (raw)
In-Reply-To: <ce8e1abb-c8aa-4e61-9e48-6006019dff6c@googlegroups.com>

[-- Attachment #1: Type: text/plain, Size: 2507 bytes --]

http://www.rubydoc.info/github/rack/rack/file/SPEC#The_Environment

On Oct 24, 2016 5:28 AM, "Olivar Plays" <arne.de.herdt@gmail.com> wrote:

> Alright,
>
> then we just need use some documentation and properly communicate this.
> At least I know where it stands now with Rack and can deal with it
> appropriately.
>
> Thank you for the information.
>
> Kind regards,
> Arne
>
> Op maandag 24 oktober 2016 14:25:15 UTC+2 schreef Lin Jen-Shin:
>>
>> Hi,
>>
>> On Mon, Oct 24, 2016 at 4:16 PM, Olivar Plays <arne.d...@gmail.com>
>> wrote:
>> > Hello,
>> >
>> > I have a small question about the behaviour of Rack when it comes to
>> headers
>> > send by clients.
>> > Are these always prefixed with HTTP_ ? Or do I need to tell my clients
>> to
>> > explicitly send them as HTTP_ ?
>>
>> I think according to Rack SPEC, all headers sent from client should be
>> prefixed
>> with HTTP_, and if your client prefix HTTP_, then you'll end up seeing
>> HTTP_HTTP_ in your Rack application.
>>
>> > Example, I'm checking on every request in my Rails application whether
>> the
>> > HTTP_COMPANY header is present, and has the correct value.
>> > But I've been running into issues with detecting them.
>> > Right now I have the client app send the headers as COMPANY, and my
>> Rails
>> > app checks as HTTP_COMPANY.
>>
>> This is intended.
>>
>> > Is this the intended behaviour, or will this go wrong again when the
>> client
>> > suddenly submits the header as HTTP_COMPANY?
>> > e.g is Rack smart enough not to prefix HTTP_COMPANY with HTTTP_ again?
>>
>> As stated above, if your client is sending HTTP_COMPANY, then you'll need
>> to
>> access it via HTTP_HTTP_COMPANY in your Rack application. Rack should
>> not try to remove the prefix, otherwise HTTP_COMPANY and COMPANY
>> would be ambiguous.
>>
>> It's designed this way to mix HTTP headers into env unambiguously.
>>
>> > Kind regards,
>> > Arne
>>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Rack Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to rack-devel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: Type: text/html, Size: 3534 bytes --]

      reply	other threads:[~2016-10-24 15:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-24  8:16 HTTP_ Headers from clients Olivar Plays
2016-10-24 12:01 ` Magnus Holm
2016-10-24 12:02 ` Lin Jen-Shin (godfat)
2016-10-24 12:28   ` Olivar Plays
2016-10-24 15:32     ` James Tucker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://groups.google.com/group/rack-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABGa_T8YajQQT99UKBqSG51ube32EiQusc5aJRX=Z8A-kwkBCw@mail.gmail.com' \
    --to=rack-devel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).