From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.229.225.21 with SMTP id iq21cs80433qcb; Wed, 10 Nov 2010 22:51:15 -0800 (PST) Return-Path: Received-SPF: pass (google.com: domain of rack-devel+bncCP_V2_zRBRDhpO7mBBoEtQ08UQ@googlegroups.com designates 10.224.197.197 as permitted sender) client-ip=10.224.197.197; Authentication-Results: mr.google.com; spf=pass (google.com: domain of rack-devel+bncCP_V2_zRBRDhpO7mBBoEtQ08UQ@googlegroups.com designates 10.224.197.197 as permitted sender) smtp.mail=rack-devel+bncCP_V2_zRBRDhpO7mBBoEtQ08UQ@googlegroups.com; dkim=pass header.i=rack-devel+bncCP_V2_zRBRDhpO7mBBoEtQ08UQ@googlegroups.com Received: from mr.google.com ([10.224.197.197]) by 10.224.197.197 with SMTP id el5mr119325qab.37.1289458274623 (num_hops = 1); Wed, 10 Nov 2010 22:51:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:received:received:mime-version :subject:from:in-reply-to:date:message-id:references:to:x-mailer :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe:content-type :content-transfer-encoding; bh=5HSvXrPGZt7/gKzxueb+O3uBsD/McNI5xCifagbgUAU=; b=05FAVr+HSaUbIUbhT3FRcvIVJQKwQu7qIm4n9mQSJ7y33wbq9bQKhw+IAg6Xb96Tmh VAPv/YBoHdj9eNf8HkkURw43zGWq4/a4QAP21THXZFB8BrAwBuLwLOjUKzjIWhQYd5KZ Ql9/LbT6vWGtyoxyrlvvsgyOr39uujIPCAffk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:mime-version:subject:from:in-reply-to:date :message-id:references:to:x-mailer:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-transfer-encoding; b=4A9izg0LymBCeqEUZbD1e1JXuUB/IKvatrKivOMWvZlONeVXiZIutHJyBYwiciQFVW NnQhjsiJm0DDxmENqGu2VC+0ohlNpGbMzZ+mfBxEc1Wg17zpBDUqpWB/sx1VuMHMGqNf ZZbZwwNDj0xU68WkqwdSjAR+86r7Ls/7RzAN8= Received: by 10.224.197.197 with SMTP id el5mr24749qab.37.1289458273059; Wed, 10 Nov 2010 22:51:13 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.229.106.83 with SMTP id w19ls588265qco.2.p; Wed, 10 Nov 2010 22:51:12 -0800 (PST) Received: by 10.229.247.200 with SMTP id md8mr58808qcb.5.1289458272140; Wed, 10 Nov 2010 22:51:12 -0800 (PST) Received: by 10.229.247.200 with SMTP id md8mr58807qcb.5.1289458272112; Wed, 10 Nov 2010 22:51:12 -0800 (PST) Received: from mail-qy0-f182.google.com (mail-qy0-f182.google.com [209.85.216.182]) by gmr-mx.google.com with ESMTP id j6si891591qcu.10.2010.11.10.22.51.11; Wed, 10 Nov 2010 22:51:11 -0800 (PST) Received-SPF: pass (google.com: domain of jftucker@gmail.com designates 209.85.216.182 as permitted sender) client-ip=209.85.216.182; Received: by mail-qy0-f182.google.com with SMTP id 5so465074qyk.20 for ; Wed, 10 Nov 2010 22:51:11 -0800 (PST) Received: by 10.229.94.143 with SMTP id z15mr453008qcm.149.1289458270946; Wed, 10 Nov 2010 22:51:10 -0800 (PST) Received: from [192.168.1.3] (24.sub-75-214-223.myvzw.com [75.214.223.24]) by mx.google.com with ESMTPS id t35sm1588960qco.30.2010.11.10.22.51.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 10 Nov 2010 22:51:09 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v1081) Subject: Re: should Rack::Response delete Content-Length on status 204? From: James Tucker In-Reply-To: Date: Wed, 10 Nov 2010 22:51:06 -0800 Message-Id: References: <2bd5f0c4-e4ca-4141-b33f-61d8d674b4e3@y31g2000vbt.googlegroups.com> <234F3B33-10DE-499B-A01B-80C574ABA000@gmail.com> To: rack-devel@googlegroups.com X-Mailer: Apple Mail (2.1081) X-Original-Sender: jftucker@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jftucker@gmail.com designates 209.85.216.182 as permitted sender) smtp.mail=jftucker@gmail.com; dkim=pass (test mode) header.i=@gmail.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable rack/rack I'll cleanup sometime On 8 Nov 2010, at 15:00, Jerry West wrote: > Sorry, noob here - do you mean chneukirchen/rack or your fork? >=20 > On second thoughts, I'll do both, apologies for the duplication. >=20 > On Nov 7, 10:09 pm, James Tucker wrote: >> Yes I think so, could you open an issue on github or a ticket on = lighthouse? I will review soon. >>=20 >> Thank you! >>=20 >> On 10 Oct 2010, at 15:40, Jerry West wrote: >>=20 >>=20 >>=20 >>=20 >>=20 >>=20 >>=20 >>> Rack::Response#finish deletes Content-Type from the header when = status >>> =3D=3D 204. >>=20 >>> Should it not also delete Content-Length too? Rack::Lint certainly >>> thinks so. >>=20 >>> And on that note should the code for #finish() not be >>=20 >>> if Utils::STATUS_WITH_NO_ENTITY_BODY.include?(status.to_i) >>=20 >>> rather than "if [204, 304].include?(status.to_i)" ... >>=20 >>> Thanks, >>> Jerry