rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / code / Atom feed
* rack 1.2.1 and ruby < 1.8.7
@ 2010-08-10 23:40 Matthew M. Boedicker
  2010-08-10 23:47 ` Matthew M. Boedicker
  0 siblings, 1 reply; 2+ messages in thread
From: Matthew M. Boedicker @ 2010-08-10 23:40 UTC (permalink / raw)
  To: rack-devel


[-- Attachment #1.1: Type: text/plain, Size: 252 bytes --]

The rack 1.2.1 gem breaks on ruby < 1.8.7 because Regexp.union does not take
an array argument. This patch fixes it. If you are opposed to changing
things to support very old versions of ruby maybe at least the gem could
require ruby 1.8.7 or greater.

[-- Attachment #1.2: Type: text/html, Size: 266 bytes --]

[-- Attachment #2: rack_utils_ruby_1_8_5_patch.txt --]
[-- Type: text/plain, Size: 399 bytes --]

--- utils.rb.orig	2010-08-10 16:30:52.203112000 -0700
+++ utils.rb	2010-08-10 16:31:08.276685000 -0700
@@ -135,7 +135,7 @@
       "'" => "&#39;",
       '"' => "&quot;",
     }
-    ESCAPE_HTML_PATTERN = Regexp.union(ESCAPE_HTML.keys)
+    ESCAPE_HTML_PATTERN = Regexp.union(*ESCAPE_HTML.keys)
 
     # Escape ampersands, brackets and quotes to their HTML/XML entities.
     def escape_html(string)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: rack 1.2.1 and ruby < 1.8.7
  2010-08-10 23:40 rack 1.2.1 and ruby < 1.8.7 Matthew M. Boedicker
@ 2010-08-10 23:47 ` Matthew M. Boedicker
  0 siblings, 0 replies; 2+ messages in thread
From: Matthew M. Boedicker @ 2010-08-10 23:47 UTC (permalink / raw)
  To: rack-devel

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Sorry for the duplicate just found the previous posts on this one.

On Tue, Aug 10, 2010 at 7:40 PM, Matthew M. Boedicker <
matthewm@boedicker.org> wrote:

> The rack 1.2.1 gem breaks on ruby < 1.8.7 because Regexp.union does not
> take an array argument. This patch fixes it. If you are opposed to changing
> things to support very old versions of ruby maybe at least the gem could
> require ruby 1.8.7 or greater.
>
>

[-- Attachment #2: Type: text/html, Size: 685 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-08-10 23:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-10 23:40 rack 1.2.1 and ruby < 1.8.7 Matthew M. Boedicker
2010-08-10 23:47 ` Matthew M. Boedicker

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/rack.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).