From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.239.138.72 with SMTP id o8cs75884hbo; Sun, 4 Jul 2010 15:20:16 -0700 (PDT) Return-Path: Received-SPF: pass (google.com: domain of rack-devel+bncCI7buMj8DBCeksThBBoERl-vWw@googlegroups.com designates 10.220.127.93 as permitted sender) client-ip=10.220.127.93; Authentication-Results: mr.google.com; spf=pass (google.com: domain of rack-devel+bncCI7buMj8DBCeksThBBoERl-vWw@googlegroups.com designates 10.220.127.93 as permitted sender) smtp.mail=rack-devel+bncCI7buMj8DBCeksThBBoERl-vWw@googlegroups.com; dkim=pass header.i=rack-devel+bncCI7buMj8DBCeksThBBoERl-vWw@googlegroups.com Received: from mr.google.com ([10.220.127.93]) by 10.220.127.93 with SMTP id f29mr298677vcs.17.1278282015858 (num_hops = 1); Sun, 04 Jul 2010 15:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:mime-version:received:received:date :message-id:subject:from:to:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=2JUjM7JulwGgAu3z75UspLDBxAIS9RWp8U0VBqUdMr4=; b=Fu/e3E4EasxlOWgsS6KW7GIRcjeRhp/5IYC+aJ+rLoZHBw7+mBejTXHsN3T8Lrk8U1 HWLvs32tv6FAzLQ/cuYca1OY8WHTf1RWzdfCwCuiuPgkD2B/IyGZPMfCfNZwYDqbEoo5 IY0b0UWhCY4FcvuRM8XzVVcxCmnRt5tR/BaK8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:mime-version:date:message-id:subject:from :to:x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe:content-type; b=Yisp1h11t/HFohbdKvyPpSXr15HY/Iso8+dKNGt9MSJ2drOZMp9DGVmfrfakmSEj/l 8U5BgI1TzReV7PAqlsMcaf72PzIVjextDFOSWGpSbg9vmZV4tlRjI7Rpno7zpSCK8AGi lxMqYhoOd1X/nm6/Gzus/alGyiao9xTckenbc= Received: by 10.220.127.93 with SMTP id f29mr72893vcs.17.1278282014720; Sun, 04 Jul 2010 15:20:14 -0700 (PDT) X-BeenThere: rack-devel@googlegroups.com Received: by 10.220.48.9 with SMTP id p9ls3549858vcf.5.p; Sun, 04 Jul 2010 15:20:13 -0700 (PDT) Received: by 10.220.194.196 with SMTP id dz4mr395418vcb.1.1278282013090; Sun, 04 Jul 2010 15:20:13 -0700 (PDT) Received: by 10.220.194.196 with SMTP id dz4mr395417vcb.1.1278282013064; Sun, 04 Jul 2010 15:20:13 -0700 (PDT) Received: from mail-qy0-f179.google.com (mail-qy0-f179.google.com [209.85.216.179]) by gmr-mx.google.com with ESMTP id w29si539511vcr.1.2010.07.04.15.20.12; Sun, 04 Jul 2010 15:20:13 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.216.179 is neither permitted nor denied by best guess record for domain of jeremy@bitsweat.net) client-ip=209.85.216.179; Received: by qyk2 with SMTP id 2so1460494qyk.17 for ; Sun, 04 Jul 2010 15:20:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.233.17 with SMTP id jw17mr966501qcb.198.1278282012567; Sun, 04 Jul 2010 15:20:12 -0700 (PDT) Received: by 10.229.47.9 with HTTP; Sun, 4 Jul 2010 15:20:12 -0700 (PDT) Date: Sun, 4 Jul 2010 15:20:12 -0700 Message-ID: Subject: Consider reverting multipart parsing change From: Jeremy Kemper To: rack-devel@googlegroups.com X-Original-Sender: jeremy@bitsweat.net X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 209.85.216.179 is neither permitted nor denied by best guess record for domain of jeremy@bitsweat.net) smtp.mail=jeremy@bitsweat.net Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=ISO-8859-1 I think acffe8ef5 should be reverted. To support an edge casey user-agent it removed the metadata from all MIME parts with a Content-Type but no filename. The idea was to have text/plain parts parse as regular params instead of file uploads. That's reasonable, but it should be limited to text/plain parts. The original issue: http://rack.lighthouseapp.com/projects/22435-rack/tickets/79 jeremy