Re: can I use Rack::Directory inside Rack::Builder block?

[Magnus Holm <judofyr@gmail.com>]

Rack::Directory is an endpoint, not a middleware:

map "/cache" do
  run Rack::Directory.new("cache")
end

// Magnus Holm



On Mon, May 24, 2010 at 19:56, Stephen Bannasch
<stephen.bannasch@deanbrook.org> wrote:
> At 3:18 AM -0400 5/24/10, Stephen Bannasch wrote:
>>I want to emulate a static web server with directory indexes using rack.
>>
>>Is there a way to use Rack::Directory inside a Rack::Builder block?
>
>
>
>
> The problem was that Rack::Directory#initialize:
>  http://github.com/chneukirchen/rack/blob/master/lib/rack/directory.rb#L45
>
> expects arguments in a different order than Rack::Builder provides:
>  http://github.com/chneukirchen/rack/blob/master/lib/rack/builder.rb#L53
>
>
> Here's what Rack::Directory#initialize looks like:
>
>  module Rack
>    class Directory
>      def initialize(root, app=nil)
>        @root = F.expand_path(root)
>        @app = app || Rack::File.new(@root)
>      end
>    end
>  end
>
>
> While Rack::Builder#use calls middleware like this:
>
>  middleware.new(app, *args, &block)
>
> Here's my simple fix:
>
>  module Rack
>    class MyDirectory < Rack::Directory
>      def initialize app, root
>        super(root, app)
>      end
>    end
>  end
>
>
>  myapp = Rack::Builder.new do
>    map "/" do
>      use Rack::MyDirectory, 'cache'
>      use Rack::Static, :urls => ["/"], :root => 'cache'
>      run lambda {|env| [404, {}, '']}
>    end
>  end
>
> Should the middleware included with rack work with Rack::Builder#use ??
>
> There don't seem to be tests for this behavior.
>
> Would these tests be useful?
>