rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / Atom feed
From: Lee Hambley <lee.hambley@gmail.com>
To: rack-devel@googlegroups.com
Subject: Re: Problem with redirects where a Rack app sits behind a proxy
Date: Sun, 28 Nov 2010 15:46:59 +0100	[thread overview]
Message-ID: <AANLkTi=M6V6r97UTz_pw2SePqnb69Po28whsvEs4_MsH@mail.gmail.com> (raw)
In-Reply-To: <d1f73ac8-d192-4cf5-a83a-98ac3b9e0239@n2g2000pre.googlegroups.com>

[-- Attachment #1: Type: text/plain, Size: 1915 bytes --]

Jon, it's the responsibility of your proxy to set X-Forwarded-For, and of
the Application to check :port if it cares about the real port, or the
X-Forwarded-For list in the case that you acknowledge the request might be
proxied.

Often XFF can be used to trick sites that use it for some `security` (not
your case) as the client can spoof it.

In case you use NGinx, at least you can specify to proxy transparently
(completely) - so your app wouldn't be any wiser.

Some proxies (Akamai) will also set a True-Client-IP header to the value set
last in XFF.

 • http://en.wikipedia.org/wiki/X-Forwarded-For

Hope that makes sense Jon (would be nice to have a standard Ruby way to look
at the proxies & original client info from the `smart` places, as it comes
up for a lot of people. Here's a snippet of a nginx backend configuration
that solved this in the easiest way for me.
https://gist.github.com/46cc2ba95794f5c92693

- Lee

On 28 November 2010 15:21, Jon Leighton <j@jonathanleighton.com> wrote:

> Hi there,
>
> I have encountered a problem with redirects with Sinatra proxied by
> Apache. Basically, the port number of the backend application server
> (Mongrel or whatever) will appear in the Location header.
>
> I've done a fairly extensive investigation here:
> https://github.com/jonleighton/redirect_test
>
> If you read README.md it basically explains everything in detail, but
> what it boils down to is this: Rack::Request#port is incorrect, in
> that it uses SERVER_PORT when no explicit port is given by
> host_with_port.
>
> Rails is not affected, since it implements its own
> ActionDispatch::Request#port method. I believe the Rails
> implementation is correct and should be implemented in Rack.
>
> If people agree with this analysis then I'm happy to produce a patch
> against Rack.
>
> Cheers,
> Jon
>
> --
> http://jonathanleighton.com/

[-- Attachment #2: Type: text/html, Size: 2631 bytes --]

  reply	other threads:[~2010-11-28 14:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-28 14:21 Problem with redirects where a Rack app sits behind a proxy Jon Leighton
2010-11-28 14:46 ` Lee Hambley [this message]
2010-11-28 15:22   ` Jon Leighton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://groups.google.com/group/rack-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=M6V6r97UTz_pw2SePqnb69Po28whsvEs4_MsH@mail.gmail.com' \
    --to=rack-devel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).