Re: ctrl-c not working in Rack::Handler::WEBrick

[James Tucker <jftucker@gmail.com>]

Stephen, 

Please see my comments on the issue.

Handlers shouldn't contain traps, Rack::Server is responsible for that.

On 12 Jul 2010, at 03:48, Stephen Bannasch wrote:

> After this commit:
> 
>  http://github.com/rack/rack/commit/e516d89ffcdad1c9d58432aaaff4a382ed3997e7
> 
>  commit <a href="/rack/rack/commit/e516d89ffcdad1c9d58432aaaff4a382ed3997e7">e516d89</a>
>  Author: raggi <jftucker@gmail.com>
>  Date:   Tue Mar 23 19:29:44 2010 +0000
> 
>      Move trap(:INT) to Rack::Server and support optional
>      Handler protocol where handlers may implement .shutdown
>      to do pre-exit cleanup.
> 
> CTRL-C no longer works to shut down webrick.
> 
> I've created an issue here: http://github.com/rack/rack/issues/#issue/35
> 
> Here's a trivial rack app with a webrick handler that shows the problem:
> 
>    require 'rack'
>    app = proc do |env|
>      [200, { 'Content-Type' => 'text/html' }, 'hello from rack and webrick']
>    end
>    server = ::Rack::Handler::WEBrick
>    server.run app, :Port => 3002
> 
> Run this and try typing ctrl-c in the console:
> 
>    $ ruby hellorack.rb
>    [2010-07-11 22:34:35] INFO  WEBrick 1.3.1
>    [2010-07-11 22:34:35] INFO  ruby 1.9.1 (2010-01-10) [i386-darwin9.8.0]
>    [2010-07-11 22:34:35] INFO  WEBrick::HTTPServer#start: pid=82455 port=3002
>    ^C[2010-07-11 22:34:37] ERROR Interrupt:
>      /Users/stephen/.rvm/rubies/ruby-1.9.1-p378/lib/ruby/1.9.1/webrick/server.rb:90:in `select'
> 
> An error is displayed but the program does not quit.
> 
> In this simple example the code at lib/rack/server.rb:208 is never executed and
> no handler is actually registered for ctrl-c:
> 
>    trap(:INT) do
>      if server.respond_to?(:shutdown)
>        server.shutdown
>      else
>        exit
>      end
>    end
> 
> Rack::Handler instances don't appear to be related to Rack::Server instances.