From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.140.199.13 with SMTP id w13cs326621rvf; Fri, 23 Oct 2009 01:51:45 -0700 (PDT) Received-SPF: pass (google.com: domain of grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com designates 10.220.4.30 as permitted sender) client-ip=10.220.4.30; Authentication-Results: mr.google.com; spf=pass (google.com: domain of grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com designates 10.220.4.30 as permitted sender) smtp.mail=grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com; dkim=pass header.i=grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com Received: from mr.google.com ([10.220.4.30]) by 10.220.4.30 with SMTP id 30mr7605087vcp.17.1256287904731 (num_hops = 1); Fri, 23 Oct 2009 01:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:received:x-sender:x-apparently-to :received:received:received:received-spf:received:dkim-signature :domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:content-type :content-transfer-encoding:reply-to:sender:precedence:x-google-loop :mailing-list:list-id:list-post:list-help:list-unsubscribe :x-beenthere-env:x-beenthere; bh=yUSF3Kt2LRbsrQIJwpjIn+RnMuQmKoLKcOJ5G/6mGuM=; b=Y45KnZuzcylUv1/4LxkYUmj9rT17YzSrB3EaC9oPQx7AKhawb0B09Vfkd5oYOCVbHG UFBui4oJlTf3vZOTHIirg+WHOxWIURMtHHdIi8LLq5YEAI2HCR813Y2qHO81ayyYhB1D H9lVd4QoWBAAcyndUNBmEK8q8BhFUg/5I2mFw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-sender:x-apparently-to:received-spf:authentication-results :dkim-signature:domainkey-signature:mime-version:in-reply-to :references:from:date:message-id:subject:to:content-type :content-transfer-encoding:reply-to:sender:precedence:x-google-loop :mailing-list:list-id:list-post:list-help:list-unsubscribe :x-beenthere-env:x-beenthere; b=KmkOUg20Yv9XWd5wtChovBa76Zyq0bJiGSoaf0fwkCFFla0wdTHXb4zbasEka9oipS lSa4nq+i2CpL772PQl29d4T7KW5jz8xc1/V7gV8SiBlXDM07jjHeMrlhhlOjhavpHYo1 gKKwy1sfTF0D8H4nrKa/BJ6kdDzGCSgFNb16k= Received: by 10.220.4.30 with SMTP id 30mr724354vcp.17.1256287904676; Fri, 23 Oct 2009 01:51:44 -0700 (PDT) Received: by 10.176.233.14 with SMTP id f14gr1713yqh.0; Fri, 23 Oct 2009 01:51:38 -0700 (PDT) X-Sender: m.fellinger@gmail.com X-Apparently-To: rack-devel@googlegroups.com Received: by 10.220.70.75 with SMTP id c11mr2960594vcj.18.1256287897306; Fri, 23 Oct 2009 01:51:37 -0700 (PDT) Received: by 10.220.70.75 with SMTP id c11mr2960593vcj.18.1256287897275; Fri, 23 Oct 2009 01:51:37 -0700 (PDT) Return-Path: Received: from mail-yx0-f171.google.com (mail-yx0-f171.google.com [209.85.210.171]) by gmr-mx.google.com with ESMTP id 25si779693ywh.4.2009.10.23.01.51.36; Fri, 23 Oct 2009 01:51:36 -0700 (PDT) Received-SPF: pass (google.com: domain of m.fellinger@gmail.com designates 209.85.210.171 as permitted sender) client-ip=209.85.210.171; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of m.fellinger@gmail.com designates 209.85.210.171 as permitted sender) smtp.mail=m.fellinger@gmail.com; dkim=pass (test mode) header.i=@gmail.com Received: by yxe1 with SMTP id 1so7692586yxe.3 for ; Fri, 23 Oct 2009 01:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=3cblHSYObFj5Uk64b+WE4xXX8SexVbJePwWnnW0y/pM=; b=QrD/A3N/z+oj+iU9gIJw//LYG2Plac7tddqh2Y6dRZFk1MrdKhg5ODKDYBCX7WP3NX 8QGS9y+Mqs7hvTC4N+1MGhvjVXsDTDCUxbk9uhd7kminy/VSmHPf2ZgpOXuLChyUXek7 LlqC5vJPz6zZeIMDRq+m4PWDTxFo1VZrbAmow= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; b=NKkJ1bmy7K7koFgk+u8R8Nz0gQx0Glych624lCv0pXGv57oqgSkQit/qiifhawIsMB Dl2KkKn8DXmHh7RO8tHm6pYIXOSVV5rMXNm71SFQDVTMBBm6i57dyabxsfXX+b38RCJL xJR+SOmorpiBCnlwGZHhIKWxvkTiJg3nAQL2w= MIME-Version: 1.0 Received: by 10.101.213.34 with SMTP id p34mr2980383anq.151.1256287896158; Fri, 23 Oct 2009 01:51:36 -0700 (PDT) In-Reply-To: <32c4a172-f5ae-426a-958c-2f0856f2ee9b@r36g2000vbn.googlegroups.com> References: <32c4a172-f5ae-426a-958c-2f0856f2ee9b@r36g2000vbn.googlegroups.com> From: Michael Fellinger Date: Fri, 23 Oct 2009 17:51:16 +0900 Message-ID: <9c00d3e00910230151p44bab9fep24fa7526b9ea5daf@mail.gmail.com> Subject: Re: patch for LSWS handler To: rack-devel@googlegroups.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Reply-To: rack-devel@googlegroups.com Sender: rack-devel@googlegroups.com Precedence: bulk X-Google-Loop: groups Mailing-List: list rack-devel@googlegroups.com; contact rack-devel+owner@googlegroups.com List-Id: List-Post: List-Help: List-Unsubscribe: , X-BeenThere-Env: rack-devel@googlegroups.com X-BeenThere: rack-devel@googlegroups.com On Fri, Oct 23, 2009 at 2:00 PM, george wrote: > > Hi, > > The LSWS handler is broken in Rack 1.0.1, the following patch should > fix it. Applied with: http://github.com/rack/rack/commit/cd401dfd01dbd8276ae817af2089c8c4d9fda6c4 > > Thanks, > George Wang > > > > *** lsws.rb =C2=A0 =C2=A0 Fri Oct 23 00:49:41 2009 > --- lsws.rb.new Fri Oct 23 00:52:10 2009 > *************** > *** 1,5 **** > --- 1,6 ---- > =C2=A0require 'lsapi' > =C2=A0require 'rack/content_length' > + require 'rack/rewindable_input' > > =C2=A0module Rack > =C2=A0 =C2=A0module Handler > *************** > *** 38,43 **** > --- 39,46 ---- > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ensure > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0body.close if body.respond_to? := close > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0end > + =C2=A0 =C2=A0 =C2=A0 ensure > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 rack_input.close > =C2=A0 =C2=A0 =C2=A0 =C2=A0end > =C2=A0 =C2=A0 =C2=A0 =C2=A0def self.send_headers(status, headers) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0print "Status: #{status}\r\n" > --=20 Michael Fellinger CTO, The Rubyists, LLC 972-996-5199