From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.103.181.8 with SMTP id i8cs325404mup; Mon, 8 Mar 2010 03:26:52 -0800 (PST) Received-SPF: pass (google.com: domain of 3-t6USwYKCrkgnmfkhogtrhnm.mkqZbj-cdudkfnnfkdfqntor.bnl@groups.bounces.google.com designates 10.91.113.20 as permitted sender) client-ip=10.91.113.20; Authentication-Results: mr.google.com; spf=pass (google.com: domain of 3-t6USwYKCrkgnmfkhogtrhnm.mkqZbj-cdudkfnnfkdfqntor.bnl@groups.bounces.google.com designates 10.91.113.20 as permitted sender) smtp.mail=3-t6USwYKCrkgnmfkhogtrhnm.mkqZbj-cdudkfnnfkdfqntor.bnl@groups.bounces.google.com; dkim=pass header.i=3-t6USwYKCrkgnmfkhogtrhnm.mkqZbj-cdudkfnnfkdfqntor.bnl@groups.bounces.google.com Received: from mr.google.com ([10.91.113.20]) by 10.91.113.20 with SMTP id q20mr1527573agm.47.1268047611907 (num_hops = 1); Mon, 08 Mar 2010 03:26:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:mime-version:received:date :in-reply-to:x-ip:references:user-agent:x-http-useragent:message-id :subject:from:to:x-original-authentication-results:x-original-sender :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:x-thread-url:x-message-url:sender:list-subscribe :list-unsubscribe:content-type:content-transfer-encoding; bh=+R0/643+7YdMxetP9P6/gUYF+Zfp9fRPFa2CgYDcXv4=; b=Nkj2twK02bNURqZTY9lD3KCENlEDz7fTxiDWpQKgMAPkyfRXkNvTpV/iVhj0AQQeud XjN4Ngsv4A7NicRUQ0ng4liv9nTvNSMM/+sJMu+wpgU2autrWkpXyttGyok726Zf30vF r+VW0XmcKFYn5jiSYmxqiHbW4BgdE0mm/2vg4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:mime-version:date:in-reply-to:x-ip :references:user-agent:x-http-useragent:message-id:subject:from:to :x-original-authentication-results:x-original-sender:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :x-thread-url:x-message-url:sender:list-subscribe:list-unsubscribe :content-type:content-transfer-encoding; b=bieRVarsv8zRTJqgTD7Eyz4Fuep9dW6X2XKyCNxLMAFEzBCv15X+p+4m5VC+7S9Xr3 D3n0SnwObYzAB2eVZMQv173a6TzC5A1IzQKmeam/hzbpKXCQS/2RzfbaIH73YEo3WrsV uUB6o990wHXvDJJejPlU5E2AciueRyX3OIwR8= Received: by 10.91.113.20 with SMTP id q20mr131261agm.47.1268047610443; Mon, 08 Mar 2010 03:26:50 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.90.163.11 with SMTP id l11ls887363age.7.p; Mon, 08 Mar 2010 03:26:49 -0800 (PST) Received: by 10.91.78.13 with SMTP id f13mr5291095agl.4.1268047608743; Mon, 08 Mar 2010 03:26:48 -0800 (PST) Received: by 10.91.78.13 with SMTP id f13mr5291087agl.4.1268047608515; Mon, 08 Mar 2010 03:26:48 -0800 (PST) Return-Path: Received: from mail-yx0-f156.google.com (mail-yx0-f156.google.com [209.85.210.156]) by gmr-mx.google.com with ESMTP id 19si117075yxe.11.2010.03.08.03.26.48; Mon, 08 Mar 2010 03:26:48 -0800 (PST) Received-SPF: pass (google.com: domain of hongli@phusion.nl designates 209.85.210.156 as permitted sender) client-ip=209.85.210.156; Received: by yxe28 with SMTP id 28so3764356yxe.9 for ; Mon, 08 Mar 2010 03:26:48 -0800 (PST) MIME-Version: 1.0 Received: by 10.101.128.18 with SMTP id f18mr124822ann.27.1268047608170; Mon, 08 Mar 2010 03:26:48 -0800 (PST) Date: Mon, 8 Mar 2010 03:26:48 -0800 (PST) In-Reply-To: <20100307235337.GA15381@dcvr.yhbt.net> X-IP: 77.250.47.10 References: <20100306075548.GB6474@dcvr.yhbt.net> <44f3f951-889e-45ec-ae46-40a371329a9e@e1g2000yqh.googlegroups.com> <20100307235337.GA15381@dcvr.yhbt.net> User-Agent: G2/1.0 X-HTTP-UserAgent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6,gzip(gfe),gzip(gfe) Message-ID: <927006e5-332c-4e59-aca6-4963bdcbea2a@q16g2000yqq.googlegroups.com> Subject: Re: Not cleaning up tempfiles for multipart? From: Hongli Lai To: Rack Development X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of hongli@phusion.nl designates 209.85.210.156 as permitted sender) smtp.mail=hongli@phusion.nl X-Original-Sender: hongli@phusion.nl Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/6eb2bc7a1f8c072c X-Message-Url: http://groups.google.com/group/rack-devel/msg/ff1a3da8e79d8efd Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Mar 8, 12:53=A0am, Eric Wong wrote: > Always? =A0Why? To simply our code. Phusion Passenger forks-without-exec worker processes from a parent. It does this on multiple levels. If I don't call exit! then a SystemExit exception will propagate through the call stack and I'd have to modify all the 'ensure' blocks in the parent to take into account they're now being executed in a child process. It's definitely possible to get rid of the exit! but it makes our code more complicated. > Doesn't Passenger have the luxury of only supporting sane platforms > that let you unlink Tempfiles and continue to use them? Yes but the Tempfile is created by Rack and on the Phusion Passenger level we have no control over those tempfiles. Even if Rack immediately unlinks those tempfiles, the actual disk space isn't released until the file handles are closed. I believe Rack currently does not even call #close on the Tempfiles. James Tucker: > So use #exit. Speed isn't everything. It's not speed. > There's no accounting for sysadmins who can't use lsof. I disagree. Software is made to be used by users, whose skills might vary significantly. Skilled sysadmins know how to use lsof and know how to take care of problems, but not everybody is or can be a skilled sysadmin. Server resources also vary greatly, and some people don't and/or cannot have have a lot of disk space. I think software should do the right thing even in the face of people who don't know how to use lsof. Charles's middleware looks simple enough. I approve.