rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / Atom feed
From: Christian Neukirchen <chneukirchen@gmail.com>
To: Rack Development <rack-devel@googlegroups.com>
Subject: [Muffin Cake] parse_query / normalize_params issues
Date: Thu, 18 Mar 2010 23:44:32 +0100	[thread overview]
Message-ID: <87wrx9i71r.fsf@gmail.com> (raw)


Date: Thu, 18 Mar 2010 15:32:19 -0700 (PDT)
From: Muffin Cake <cakemuffin10@yahoo.com>
Subject: parse_query / normalize_params issues
To: chneukirchen@gmail.com

Hey,

Rack  is great.

I found a small issue, that took me quite a while to uncover though:

In parse_query and normalize_params there is a special case when a param starts and ends with " or '. And it removes them. What is the reasoning behind this?

app?q="a"      -->  {"q"=>"a"}   instead of {"q"=>"\"a\""}

eg. compare to google, searching for "funny quotes"

There is even a test case for this behaviour, which I found oddly surprising.

Thanks!

             reply	other threads:[~2010-03-18 22:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18 22:44 Christian Neukirchen [this message]
2010-03-19 21:13 ` parse_query / normalize_params issues Simon Chiang
2010-04-29 22:08 ` [Muffin Cake] " Ryan Tomayko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://groups.google.com/group/rack-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wrx9i71r.fsf@gmail.com \
    --to=rack-devel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).