rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / Atom feed
From: James Tucker <jftucker@gmail.com>
To: rack-devel@googlegroups.com
Subject: Re: Questions about the Prohibition of String Subclasses in responses
Date: Tue, 6 Oct 2009 15:23:42 +0100	[thread overview]
Message-ID: <6DBE7E40-C9AC-46CA-8593-4B9AD9EC6074@gmail.com> (raw)
In-Reply-To: <ef46c93e0910052340r60a5ecf3i16d9f2ba5291065b@mail.gmail.com>



On 6 Oct 2009, at 07:40, Michael Koziarski wrote:

>
>> Fortunately I don't know of any extensions that crazy as there's no
>> point in subclassing at that point.  And if there are, maybe people
>> using them deserve to get their apps broken :>
>
> Seems very unlikely yeah.
>
>>> Having said that, I've been surprised before
>>
>> Part of me wants to apply this change and stick it into a release  
>> just
>> to see what (if anything it) breaks.  Fortunately for the rest of you
>> I'm not part of the Rack core team :)
>
> ditto on all points :)

I've just moved us over to kind_of in Lint from instance_of, in all  
cases of instance_of. Generally speaking the spec needs to ensure that  
the types supplied can be sent straight to IO.

I think if anyone uses a type to breach this, they should find the  
bugs appear in their own apps for reasonably well expected reasons,  
although most errors will show up in the handlers themselves.

I've also cherry picked for the 1.0.1 release.

>
> -- 
> Cheers
>
> Koz

  reply	other threads:[~2009-10-06 14:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-05 21:58 Questions about the Prohibition of String Subclasses in responses Michael Koziarski
2009-10-05 23:02 ` Eric Wong
2009-10-05 23:22   ` Eric Wong
2009-10-06  0:38     ` Michael Koziarski
2009-10-06  2:52       ` Eric Wong
2009-10-06  6:40         ` Michael Koziarski
2009-10-06 14:23           ` James Tucker [this message]
2009-10-06  8:05     ` James Tucker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://groups.google.com/group/rack-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6DBE7E40-C9AC-46CA-8593-4B9AD9EC6074@gmail.com \
    --to=rack-devel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).