From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.239.138.72 with SMTP id o8cs186350hbo; Sun, 13 Jun 2010 14:11:55 -0700 (PDT) Return-Path: Received-SPF: pass (google.com: domain of rack-devel+bncCP_V2_zRBRCZk9XgBBoEiNNUqA@googlegroups.com designates 10.220.125.24 as permitted sender) client-ip=10.220.125.24; Authentication-Results: mr.google.com; spf=pass (google.com: domain of rack-devel+bncCP_V2_zRBRCZk9XgBBoEiNNUqA@googlegroups.com designates 10.220.125.24 as permitted sender) smtp.mail=rack-devel+bncCP_V2_zRBRCZk9XgBBoEiNNUqA@googlegroups.com; dkim=pass header.i=rack-devel+bncCP_V2_zRBRCZk9XgBBoEiNNUqA@googlegroups.com Received: from mr.google.com ([10.220.125.24]) by 10.220.125.24 with SMTP id w24mr827687vcr.30.1276463514448 (num_hops = 1); Sun, 13 Jun 2010 14:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:received:received:mime-version :subject:from:in-reply-to:date:message-id:references:to:x-mailer :x-original-authentication-results:x-original-sender:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe:content-type :content-transfer-encoding; bh=Xdg7N6v4BwF/iz1wYR1Mih0vDtN3+y0+dNPmBtNx/M8=; b=aqlHZw2XTtloP+S3tDax2Lp7+P0keVZYZYYE3sVQd4JaqSgl/Tj3cW+vBgmbk7r82H 1jjn3KptEBR/FrSTe66/HzRaq3a6TNuNexgawwcHjvLsR39CCNVUZmOsqGysx21CL2ds gMJcGmOl/1WGgQ/c0pkpW0VWXfS5n6vn6zQJ4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:mime-version:subject:from:in-reply-to:date :message-id:references:to:x-mailer:x-original-authentication-results :x-original-sender:reply-to:precedence:mailing-list:list-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-transfer-encoding; b=4O908FU1jmFx87mqNAyEvnn+hJMTJoMqx3TQCV6/jlNAzsoaZSDKRPE2mjToWBBfFF StBALrDLF3hc80DoYT9SW0gSpproTkoUVrTXo/B9N5cjSM/O0d3tfKIpvgY8bcCtigGD 0ZQFJU+tskjzqyfQJw/jqMKaMQyjNENwCNoWM= Received: by 10.220.125.24 with SMTP id w24mr176924vcr.30.1276463513214; Sun, 13 Jun 2010 14:11:53 -0700 (PDT) X-BeenThere: rack-devel@googlegroups.com Received: by 10.220.80.27 with SMTP id r27ls583711vck.0.p; Sun, 13 Jun 2010 14:11:52 -0700 (PDT) Received: by 10.220.169.144 with SMTP id z16mr618677vcy.27.1276463512418; Sun, 13 Jun 2010 14:11:52 -0700 (PDT) Received: by 10.220.169.144 with SMTP id z16mr618676vcy.27.1276463512401; Sun, 13 Jun 2010 14:11:52 -0700 (PDT) Received: from mail-vw0-f52.google.com (mail-vw0-f52.google.com [209.85.212.52]) by gmr-mx.google.com with ESMTP id g35si543707vck.5.2010.06.13.14.11.51; Sun, 13 Jun 2010 14:11:51 -0700 (PDT) Received-SPF: pass (google.com: domain of jftucker@gmail.com designates 209.85.212.52 as permitted sender) client-ip=209.85.212.52; Received: by vws3 with SMTP id 3so1206567vws.25 for ; Sun, 13 Jun 2010 14:11:51 -0700 (PDT) Received: by 10.229.181.16 with SMTP id bw16mr1933558qcb.223.1276463511159; Sun, 13 Jun 2010 14:11:51 -0700 (PDT) Received: from [192.168.101.2] ([199.172.234.49]) by mx.google.com with ESMTPS id m29sm10631335qck.28.2010.06.13.14.11.49 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 13 Jun 2010 14:11:50 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v1078) Subject: Re: Patch: Make CGI handler obey rack spec for the greater good From: James Tucker In-Reply-To: <9c6dabb0-9ccc-45af-b370-c84a1527d6ad@k39g2000yqd.googlegroups.com> Date: Sun, 13 Jun 2010 18:11:47 -0300 Message-Id: <6B5DF158-7394-42E7-AF34-830E016E7854@gmail.com> References: <42cbee50-0818-4c65-a5f5-252f0b18f885@o39g2000vbd.googlegroups.com> <9c6dabb0-9ccc-45af-b370-c84a1527d6ad@k39g2000yqd.googlegroups.com> To: rack-devel@googlegroups.com X-Mailer: Apple Mail (2.1078) X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jftucker@gmail.com designates 209.85.212.52 as permitted sender) smtp.mail=jftucker@gmail.com; dkim=pass (test mode) header.i=@gmail.com X-Original-Sender: jftucker@gmail.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable On 12 Jun 2010, at 15:46, Max Cantor wrote: > On May 20, 5:10 pm, James Tucker wrote: >> On 20 May 2010, at 14:36, Max Cantor wrote: >>> Do you feel like there's a good reason to not make the CGI handler's >>> input stream rewindable? Every time I update rack, I have to = re-patch >>> it myself, because it never works. It seems pretty unintuitive to >>> require adding middleware just to make the CGI handler work at all. >>=20 >> I just don't see really good reasons to buffer for the sake of = buffering. >=20 > I'm not suggesting that we buffer for the sake of buffering... the CGI > handler literally does not work for me without this patch. I don't > think I'm doing anything very idiosyncratic: Just a basic rack app > with lighttpd. If there's some way I can reconfigure my environment > to obviate the need for this patch, I can do that, but it seems like > the handler's lack of adherence to the spec is making it break. The spec went the way of requiring rewind. I'm not sure what the = conditions are that $stdin isn't rewindable, but your patch is valid to = solve the problem. Sadly, it just missed release :-/