rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / code / Atom feed
* Rack::ETag joins forces with Rack::ConditionalGet
@ 2010-03-04 20:46 Jeremy Kemper
  2010-03-04 20:48 ` Jeremy Kemper
  0 siblings, 1 reply; 2+ messages in thread
From: Jeremy Kemper @ 2010-03-04 20:46 UTC (permalink / raw)
  To: rack-devel

Rack::ETag sets the ETag response header if it's missing, but doesn't
check If-None-Match.

Rack::ConditionalGet checks If-None-Match, but doesn't set ETag
response header if missing.

It's conceivable but rare to use them in isolation, and their separate
leads to error-prone middleware stacks.

Rack::ETag should be deprecated and folded in to ConditionalGet:

4c782ba76a88803500d726af718784584cf215cc

jeremy

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Rack::ETag joins forces with Rack::ConditionalGet
  2010-03-04 20:46 Rack::ETag joins forces with Rack::ConditionalGet Jeremy Kemper
@ 2010-03-04 20:48 ` Jeremy Kemper
  0 siblings, 0 replies; 2+ messages in thread
From: Jeremy Kemper @ 2010-03-04 20:48 UTC (permalink / raw)
  To: rack-devel

On Thu, Mar 4, 2010 at 12:46 PM, Jeremy Kemper <jeremy@bitsweat.net> wrote:
> Rack::ETag sets the ETag response header if it's missing, but doesn't
> check If-None-Match.
>
> Rack::ConditionalGet checks If-None-Match, but doesn't set ETag
> response header if missing.
>
> It's conceivable but rare to use them in isolation, and their separate
> leads to error-prone middleware stacks.
>
> Rack::ETag should be deprecated and folded in to ConditionalGet:
>
> 4c782ba76a88803500d726af718784584cf215cc

That is,
http://github.com/jeremy/rack/commit/4c782ba76a88803500d726af718784584cf215cc

jeremy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-03-04 20:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-04 20:46 Rack::ETag joins forces with Rack::ConditionalGet Jeremy Kemper
2010-03-04 20:48 ` Jeremy Kemper

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/rack.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).