From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.140.140.3 with SMTP id n3cs223804rvd; Thu, 4 Mar 2010 12:13:19 -0800 (PST) Received-SPF: pass (google.com: domain of 3XBSQSwYMCkwxs5s0Cpw76Aso7.1s75oqy-rs9szu22uzsu52836.q20@groups.bounces.google.com designates 10.220.123.197 as permitted sender) client-ip=10.220.123.197; Authentication-Results: mr.google.com; spf=pass (google.com: domain of 3XBSQSwYMCkwxs5s0Cpw76Aso7.1s75oqy-rs9szu22uzsu52836.q20@groups.bounces.google.com designates 10.220.123.197 as permitted sender) smtp.mail=3XBSQSwYMCkwxs5s0Cpw76Aso7.1s75oqy-rs9szu22uzsu52836.q20@groups.bounces.google.com; dkim=pass header.i=3XBSQSwYMCkwxs5s0Cpw76Aso7.1s75oqy-rs9szu22uzsu52836.q20@groups.bounces.google.com Received: from mr.google.com ([10.220.123.197]) by 10.220.123.197 with SMTP id q5mr1918944vcr.33.1267733598926 (num_hops = 1); Thu, 04 Mar 2010 12:13:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:mime-version:received:date :message-id:subject:from:to:x-original-authentication-results :x-original-sender:reply-to:precedence:mailing-list:list-id :list-post:list-help:list-archive:x-thread-url:x-message-url:sender :list-subscribe:list-unsubscribe:content-type; bh=HHYNNmjK6Bfur7vbp+S4wbtWMyFeN+VhJrpHMgbXqQI=; b=0lxS06HRtQNQXrnb2wOA08jKSCe6fADOUvInKJy/fWe+XcyRn2lbaIUAlOYfJzhiu1 ustV6BS1IgOI+crDPytNT3qH0+6Vcd+m2gsVID+dPnqeW1Pm8VIsuxFtz4ufn/I3En5j DlP2gQcITzrvC72MQqK6Q+nGc4pj3kFu5TA1I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:mime-version:date:message-id:subject:from :to:x-original-authentication-results:x-original-sender:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :x-thread-url:x-message-url:sender:list-subscribe:list-unsubscribe :content-type; b=V4rs9LQ3miREC7TkQG8hdEaJLduRXr7vYvRi6RpwteHqyH8u75vYt7vOWmHleAfRxA jUGLZZbbhNsYmjG9JVLaFBCkJYmBtyTfgqxS5jXvR+zPC7j1SMk0m67CONDyVfKal/rq Rj2lGilyzn6JYCGq7dobKwg0MgkANXku4YfMk= Received: by 10.220.123.197 with SMTP id q5mr219438vcr.33.1267733597674; Thu, 04 Mar 2010 12:13:17 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.220.68.219 with SMTP id w27ls660280vci.1.p; Thu, 04 Mar 2010 12:13:16 -0800 (PST) Received: by 10.220.65.19 with SMTP id g19mr1034920vci.24.1267733595950; Thu, 04 Mar 2010 12:13:15 -0800 (PST) Received: by 10.220.65.19 with SMTP id g19mr1034919vci.24.1267733595931; Thu, 04 Mar 2010 12:13:15 -0800 (PST) Return-Path: Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.26]) by gmr-mx.google.com with ESMTP id 31si649632vws.1.2010.03.04.12.13.15; Thu, 04 Mar 2010 12:13:15 -0800 (PST) Received-SPF: neutral (google.com: 74.125.92.26 is neither permitted nor denied by best guess record for domain of jeremy@bitsweat.net) client-ip=74.125.92.26; Received: by qw-out-2122.google.com with SMTP id 5so555633qwi.47 for ; Thu, 04 Mar 2010 12:13:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.98.129 with SMTP id q1mr1581536qcn.100.1267733595321; Thu, 04 Mar 2010 12:13:15 -0800 (PST) Date: Thu, 4 Mar 2010 12:13:15 -0800 Message-ID: <69a2885c1003041213x3265bf52ga7ad4599b2fcb19b@mail.gmail.com> Subject: Rack::ConditionalGet should check for ETag header, not Etag From: Jeremy Kemper To: rack-devel@googlegroups.com X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 74.125.92.26 is neither permitted nor denied by best guess record for domain of jeremy@bitsweat.net) smtp.mail=jeremy@bitsweat.net X-Original-Sender: jeremy@bitsweat.net Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/33d5b0eaea2038f X-Message-Url: http://groups.google.com/group/rack-devel/msg/3b59330204cfc167 Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=ISO-8859-1 For your consideration: a bug fix for Rack::ConditionalGet. The middleware checks for headers['Etag'] when it should be checking for 'ETag'. The bug is masked by the specs which use a case-indifferent HeaderHash. Fixed and added a spec that returns a headers Hash. http://github.com/jeremy/rack/commit/e59456ade9f7d4e82742913bbcad927ca5e28859 jeremy